New behaviour of GetMinPayoff and GetMaxPayoff to refer to plays of games#655
Merged
New behaviour of GetMinPayoff and GetMaxPayoff to refer to plays of games#655
GetMinPayoff and GetMaxPayoff to refer to plays of games#655Conversation
…nal/missing terminal outcomes
rahulsavani
approved these changes
Dec 2, 2025
Member
rahulsavani
left a comment
rahulsavani
left a comment
There was a problem hiding this comment.
Looks good to me.
I added some new tests for min_payoff and max_payoff and, using the same, also for lp_solve, lcp_solve. These games have variants (with the same reduced strategic form) where there are non-terminal outcomes or missing terminal outcomes. Some of these will xfail for {lp,lcp}_solve at the moment, but will pass when issue #654 is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do/discuss:
Closes #498.