Correct regression in information set drawing.#645
Merged
Conversation
Member
Author
|
@rahulsavani this now works on your example, check any others you might have before I merge. |
rahulsavani
approved these changes
Nov 25, 2025
Member
rahulsavani
left a comment
rahulsavani
left a comment
There was a problem hiding this comment.
I tested 6 games with absent-mindedness from the test suite and all had the "infoset connecter" missing on master and back to normal on fix_infoset_drawing.
When removing options for changing how information sets are drawn, the arrows indicating information sets at multiple levels were lost. This corrects that regression. Closes #643.
tturocy
force-pushed
the
fix_infoset_drawing
branch
from
cddb93f to
61937c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing options for changing how information sets are drawn, the arrows indicating information sets
at multiple levels were lost.
This corrects that regression.
Closes #643.