Conversation
doc/developer.contributing.rst
Outdated
|
|
||
| - `pyproject.toml` | ||
| - `doc/conf.py` | ||
| - `configure.ac` |
There was a problem hiding this comment.
This is a non-exhaustive list, @tturocy do you tend to update the version number in all these places and elsewhere when releasing, or is there one place where the version number gets propagated throughout the codebase?
There was a problem hiding this comment.
It's done manually. It could be useful to use one of the various version-bumping tools that's out there to help automate this.
…ment and generate gambit.wxs and Info.plist files automatically
|
At the risk of some scope creep, would it be a good idea whilst we are in the neighbourhood to rationalise the locations of the various build-support files? At the moment we have:
(Separately note I've removed the very old It would seem a good idea to to have a directory for these - what would be a good name ( |
tturocy
left a comment
There was a problem hiding this comment.
See note in conversation about thinking about directory structure for input files, and putting generated files in build/ somewhere.
* Refactor build support files into build_support directory * Update GAMBIT_VERSION path in configure.ac to use build_support directory
@tturocy I have moved these into |
* Don't version generated files (in fact the non .in versions of the build_support files aren't being updated) * Use OS-specific directories in build_support
|
I've pushed a few further amendments:
Waiting to see whether the actions run into any problems, but it would also be good to check my work! |
|
@edwardchalstrey1 @rahulsavani Looks like the GitHub actions ran successfully, so no obvious internal problems. Can you both please have a look to see whether we have done everything here that it makes sense to do as far as rationalising the organisation of the build config and SPOTing the version number? Once we've done that we'll get this merged (it's going to make releasing so much easier...) |
Looks good to me |
Closes #560
@tturocy @rahulsavani I believe this captures the current processes as they stand, let me know if not
Page: https://gambitproject--628.org.readthedocs.build/en/628/developer.contributing.html#releases-maintenance-branches
See also the comment below on the addition of the
GAMBIT_VERSIONfile