Add tests for legacy Node.is_subgame_root#624
Merged
tturocy merged 5 commits intogambitproject:masterfrom Nov 18, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an improved test suite for the legacy
Node.is_subgame_rootmethod. This work serves as a preparatory step for the refactoring the legacy subgames detector using a novel approach.The test suite covers several key scenarios to establish a clear baseline of the current implementation's behavior:
Games where
is_subgame_rootbehaves correctly (e02.efg,wichardt.efg,subgames.efg).A game with an absent-minded information set (
AM-driver-subgame.efg) where the legacy method is known to fail.The failing test is marked with
@pytest.mark.xfailto formally document this limitation, as requested.Closes #583