weaker test for enumpoly that ignores output order#590
Merged
Conversation
Member
Author
|
I have re-run the relevant Windows test 10 times in total and it never failed. We can do some repeat runs of that on this PR too. |
Member
Author
OK, it's passed 10 re-runs since the PR: https://github.com/gambitproject/gambit/actions/runs/19191745733 One thing to note is that in both the ordered and unordered versions, now maxregret is set at 1e-4, rather than using the default (1e-3). The tests will probably repeatedly pass with the default regret, if we prefer to revert to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #589
The tests for enumpoly_solve in mixed behaviors included a 3-player game where the order of equilibria found varies from run to run on Windows under the github tests action -- as a result, tests would sometimes pass and sometimes fail, since this test expects a pre-defined order of output equilibria.
That old test has been renamed: test_enumpoly_behavior_rational -> test_enumpoly_ordered_behavior_rational, and the new test_enumpoly_unordered_behavior_rational, which checks all found equilibria are in a pre-defined set, has been added.