tests for EFG Nash solvers -- enumpoly, lp, lcp -- in behavior strategies#586
Merged
tests for EFG Nash solvers -- enumpoly, lp, lcp -- in behavior strategies#586
Conversation
tturocy
requested changes
Nov 7, 2025
Member
tturocy
left a comment
tturocy
left a comment
There was a problem hiding this comment.
See comments. The game-building can be expressed much more felicitously. And indeed should we consider building Kuhn poker also to a more prominent example in the documentation somewhere? It's far more engaging than the one-card "stripped down" poker (although it poses some practical challenges as we have been discussing). That could be spun off into a separate discussion.
tests/games.py
Outdated
| A: np.ndarray, B: np.ndarray, title: str | ||
| ) -> gbt.Game: | ||
| """ | ||
| There is not direct pygambit method to create an EFG from a stategic-form game. |
Member
There was a problem hiding this comment.
It could be interesting functionality possibly to have some transformation that does this. But we would have to think a bit more about how it might be implemented, so probably just fine to leave it as an auxiliary function here.
rahulsavani
force-pushed
the
extend_nash_solver_tests_for_EFGs
branch
from
a509e01 to
02d3d48
Compare
rahulsavani
force-pushed
the
extend_nash_solver_tests_for_EFGs
branch
from
02d3d48 to
5a2898a
Compare
tturocy
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.