Issue 533

.clang-tidy

@@ -7,15 +7,12 @@ Checks: |
   -modernize-avoid-c-arrays,
   -modernize-pass-by-value,
   -modernize-use-nodiscard,
-  -modernize-concat-nested-namespaces,
   cppcoreguidelines-pro-type-cstyle-cast,
   cppcoreguidelines-pro-type-member-init,
   cppcoreguidelines-prefer-member-initializer,
   misc-const-correctness
 WarningsAsErrors: '*'
-# Don't bother with wxWidgets headers
-HeaderFilterRegex: '^((?!labenski).)*$'
-AnalyzeTemporaryDtors: false
+HeaderFilterRegex: '.*'
 FormatStyle:     none
 User:            arbiter
 CheckOptions:

.github/workflows/lint.yml

@@ -11,7 +11,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run clang-format style check for C/C++
-        uses: jidicula/clang-format-action@v4.14.0
+        uses: jidicula/clang-format-action@v4.15.0
         with:
           clang-format-version: '17'
           check-path: 'src'

.github/workflows/osxbinary.yml

@@ -0,0 +1,37 @@
+name: MacOS static GUI binary
+
+on:
+  push:
+    tags:
+      - 'v*'
+  schedule:
+    - cron: '0 6 * * 4'
+
+jobs:
+  macos-13:
+    runs-on: macos-13
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install dependencies
+        run: |
+            brew install automake autoconf
+            curl -L -O https://github.com/wxWidgets/wxWidgets/releases/download/v3.2.6/wxWidgets-3.2.6.tar.bz2
+            tar xjf wxWidgets-3.2.6.tar.bz2
+            cd wxWidgets-3.2.6
+            mkdir build-release
+            cd build-release
+            ../configure --disable-shared --disable-sys-libs
+            make -j4
+            sudo make install
+      - run: aclocal
+      - run: automake --add-missing
+      - run: autoconf
+      - run: ./configure
+      - run: make
+      - run: sudo make install
+      - run: make osx-dmg
+      - uses: actions/upload-artifact@v4
+        with:
+          name: artifact-osx-13
+          path: "*.dmg"

.github/workflows/python.yml

@@ -10,7 +10,7 @@ jobs:
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.9', '3.12']
+        python-version: ['3.9', '3.13']
 
     steps:
       - uses: actions/checkout@v4
@@ -21,23 +21,69 @@ jobs:
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install setuptools cython pytest wheel lxml numpy scipy
+          pip install setuptools build cython pytest pytest-skip-slow wheel lxml numpy scipy
       - name: Build source distribution
         run:
-          python setup.py sdist
+          python -m build
       - name: Build from source distribution
         run: |
           cd dist
           pip install -v pygambit*.tar.gz
       - name: Run tests
         run: pytest
 
+  macos-13:
+    runs-on: macos-13
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
+    strategy:
+      matrix:
+        python-version: ['3.13']
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Set up dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
+      - name: Build extension
+        run: |
+          python -m pip install -v .
+      - name: Run tests
+        run: pytest
+
+  macos-14:
+    runs-on: macos-14
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
+    strategy:
+      matrix:
+        python-version: ['3.13']
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Set up dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
+      - name: Build extension
+        run: |
+          python -m pip install -v .
+      - name: Run tests
+        run: pytest
+
   windows:
     runs-on: windows-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.12']
+        python-version: ['3.13']
 
     steps:
       - uses: actions/checkout@v4
@@ -48,7 +94,7 @@ jobs:
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install cython pytest wheel lxml numpy scipy
+          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
       - name: Build extension
         run: |
           python -m pip install -v .

.github/workflows/tools.yml

@@ -34,8 +34,8 @@ jobs:
           make
           sudo make install
 
-  macos-13:
-    runs-on: macos-13
+  macos:
+    runs-on: macos-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
       - uses: actions/checkout@v4
@@ -50,26 +50,7 @@ jobs:
       - run: make osx-dmg
       - uses: actions/upload-artifact@v4
         with:
-          name: artifact-osx-13
-          path: "*.dmg"
-
-  macos-14:
-    runs-on: macos-14
-    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
-    steps:
-      - uses: actions/checkout@v4
-      - name: Install dependencies
-        run: brew install automake autoconf wxwidgets
-      - run: aclocal
-      - run: automake --add-missing
-      - run: autoconf
-      - run: ./configure
-      - run: make
-      - run: sudo make install
-      - run: make osx-dmg
-      - uses: actions/upload-artifact@v4
-        with:
-          name: artifact-osx-14
+          name: artifact-osx
           path: "*.dmg"
 
   windows:

ChangeLog

@@ -2,11 +2,28 @@
 
 ## [16.4.0] - unreleased
 
-### Removed
+### General
+- Officially added support for Python 3.13.
 
+### Removed
 - The deprecated functions `Game.read_game`, `Game.parse_game` and `Game.write` functions have
   been removed as planned. (#357)
 
+### Added
+- Implement `GetPlays()` (C++) and `get_plays` (Python) to compute the set of terminal nodes consistent
+  with a node, information set, or action (#517)
+- Implement `GameStrategyRep::GetAction` (C++) and `Strategy.action` (Python) retrieving the action
+    prescribed by a strategy at an information set
+- Tests for creation of the reduced strategic form from an extensive-form game (currently only
+  for games with perfect recall)
+
+
+## [16.3.1] - unreleased
+
+### Fixed
+- Corrected a regression in which information sets were prematurely invalidated (and therefore
+  `delete this` called on them) when removing the last node from an information set.
+
 
 ## [16.3.0] - 2025-01-13
 
@@ -50,6 +67,12 @@
   Explorer, as GTE no longer reads files in this format.
 
 
+## [16.2.2] - unreleased
+
+### Fixed
+- `Game.copy_tree` and `Game.move_tree` implementations reversed the roles of the
+  `src` and `dest` nodes (#499)
+
 ## [16.2.1] - 2025-01-06
 
 ### Fixed
@@ -60,7 +83,6 @@
 - Attempting to call the default constructor on Game objects (rather than one of the factory
   functions) now raises a more informative exception (#463)
 
-
 ## [16.2.0] - 2024-04-05
 
 ### Fixed

Makefile.am

@@ -245,6 +245,8 @@ EXTRA_DIST = \
 	src/README.rst
 
 core_SOURCES = \
+    src/core/core.h \
+    src/core/util.h \
 	src/core/array.h \
 	src/core/list.h \
 	src/core/vector.h \
@@ -312,12 +314,7 @@ game_SOURCES = \
 	src/games/nash.h
 
 linalg_SOURCES = \
-	src/solvers/linalg/basis.cc \
-	src/solvers/linalg/basis.h \
-	src/solvers/linalg/bfs.h \
-	src/solvers/linalg/btableau.cc \
 	src/solvers/linalg/btableau.h \
-	src/solvers/linalg/btableau.imp \
 	src/solvers/linalg/lpsolve.cc \
 	src/solvers/linalg/lpsolve.h \
 	src/solvers/linalg/lpsolve.imp \
@@ -391,6 +388,7 @@ gambit_enummixed_SOURCES = \
 	src/solvers/enummixed/clique.h \
 	src/solvers/enummixed/enummixed.cc \
 	src/solvers/enummixed/enummixed.h \
+	src/tools/util.h \
 	src/tools/enummixed/enummixed.cc
 
 gambit_nashsupport_SOURCES = \
@@ -419,11 +417,13 @@ gambit_enumpoly_SOURCES = \
 	src/solvers/enumpoly/efgpoly.cc \
 	src/solvers/enumpoly/nfgpoly.cc \
 	src/solvers/enumpoly/enumpoly.h \
+	src/tools/util.h \
 	src/tools/enumpoly/enumpoly.cc
 
 gambit_enumpure_SOURCES = \
 	${core_SOURCES} ${game_SOURCES} \
 	src/solvers/enumpure/enumpure.h \
+	src/tools/util.h \
 	src/tools/enumpure/enumpure.cc
 
 gambit_gnm_SOURCES = \
@@ -440,6 +440,7 @@ gambit_ipa_SOURCES = \
 	src/solvers/ipa/ipa.cc \
 	src/solvers/ipa/ipa.h \
 	src/tools/gt/nfggt.cc \
+	src/tools/util.h \
 	src/tools/gt/nfgipa.cc
 
 gambit_lcp_SOURCES = \
@@ -448,13 +449,15 @@ gambit_lcp_SOURCES = \
 	src/solvers/lcp/efglcp.cc \
 	src/solvers/lcp/nfglcp.cc \
 	src/solvers/lcp/lcp.h \
+	src/tools/util.h \
 	src/tools/lcp/lcp.cc
 
 gambit_liap_SOURCES = \
 	${core_SOURCES} ${game_SOURCES} \
 	src/solvers/liap/efgliap.cc \
 	src/solvers/liap/nfgliap.cc \
 	src/solvers/liap/liap.h \
+	src/tools/util.h \
 	src/tools/liap/liap.cc
 
 gambit_logit_SOURCES = \
@@ -466,21 +469,22 @@ gambit_logit_SOURCES = \
     src/solvers/logit/logit.h \
 	src/solvers/logit/efglogit.cc \
 	src/solvers/logit/nfglogit.cc \
+	src/tools/util.h \
 	src/tools/logit/logit.cc
 
 gambit_lp_SOURCES = \
 	${core_SOURCES} ${game_SOURCES} \
 	${linalg_SOURCES} \
-	src/solvers/lp/efglp.cc \
-	src/solvers/lp/efglp.h \
-	src/solvers/lp/nfglp.cc \
-	src/solvers/lp/nfglp.h \
+	src/solvers/lp/lp.cc \
+	src/solvers/lp/lp.h \
+	src/tools/util.h \
 	src/tools/lp/lp.cc
 
 gambit_simpdiv_SOURCES = \
 	${core_SOURCES} ${game_SOURCES} \
 	src/solvers/simpdiv/simpdiv.cc \
 	src/solvers/simpdiv/simpdiv.h \
+	src/tools/util.h \
 	src/tools/simpdiv/nfgsimpdiv.cc
 
 gambit_SOURCES = \
@@ -634,8 +638,7 @@ msw-msi:
 	light -ext WixUIExtension gambit.wixobj
 
 clang-tidy:
-	clang-tidy ${top_srcdir}/src/core/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/games/*.cc ${top_srcdir}/src/games/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/solvers/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/tools/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/gui/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/core/*.cc -- --std=c++17 -I ${top_srcdir}/src -DVERSION=""
+	clang-tidy ${top_srcdir}/src/games/*.cc ${top_srcdir}/src/games/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -DVERSION=""
+	clang-tidy ${top_srcdir}/src/solvers/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -DVERSION=""
+	clang-tidy ${top_srcdir}/src/tools/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -DVERSION=""