Skip to content

Issue 517: adding GameRep::GetPlays for Node, Infoset, and Action; exposing it to Cython#521

Closed
d-kad wants to merge 11 commits intogambitproject:masterfrom
d-kad:issue_517
Closed

Issue 517: adding GameRep::GetPlays for Node, Infoset, and Action; exposing it to Cython#521
d-kad wants to merge 11 commits intogambitproject:masterfrom
d-kad:issue_517

Conversation

@d-kad
Copy link
Copy Markdown
Contributor

@d-kad d-kad commented May 13, 2025

Currently work in progress:

@tturocy I tried to extend Game.get_plays to cover the cases of Infoset and Action.
This Cython code does not compile after introducing new GetPlays overloads.
When there is a single overload for Node alone in commit b767236, it compiles.

Could you please help?

@d-kad d-kad requested a review from tturocy May 14, 2025 11:23
@d-kad d-kad requested a review from tturocy May 16, 2025 17:07
Copy link
Copy Markdown
Member

@tturocy tturocy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we're adding/changing something public, we should also have the following:

  • Appropriate entry in ChangeLog
  • Add function to the documentation index (doc/pygambit.api.rst) in appropriate location
  • Consider adding a user guide section (doc/pygambit.user.rst) which illustrates the use/usefulness of the functions.

@d-kad d-kad requested a review from tturocy May 19, 2025 12:09
@tturocy
Copy link
Copy Markdown
Member

tturocy commented May 20, 2025

Merged at 7df3d34.

@tturocy tturocy closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants