Issue 491

[d-kad]

• add GameTreeRep::m_numNodes field and expose it in NumNodes
• reimplement Game.nodes as a property of class Game
• add tests for new functionality of GameNodes.__len__

solves #491

[d-kad]

In test_realiz_prob_nodes_reference (test_behav.py) I had to change associations between node indices and probabilities as the traversal order for nodes has changed, seemingly due to the added dfs in GameNodes.__iter__

@tturocy should we keep it as is or should the old order be restored?

[tturocy]

In test_realiz_prob_nodes_reference (test_behav.py) I had to change associations between node indices and probabilities as the traversal order for nodes has changed, seemingly due to the added dfs in GameNodes.__iter__

@tturocy should we keep it as is or should the old order be restored?

In test_realiz_prob_nodes_reference (test_behav.py) I had to change associations between node indices and probabilities as the traversal order for nodes has changed, seemingly due to the added dfs in GameNodes.__iter__

@tturocy should we keep it as is or should the old order be restored?

This is happening because of the order you're yielding nodes in the recursive iterator. Switch it so that you yield the node first then its children - this will match the previous behaviour. No need to change behaviour here unnecessarily!

This is a nice example though of how that particular test is a bit fragile and why having something like node paths will be an important improvement to develop.

[tturocy]

Merged as 0a04bab.