Skip to content

Issue 499#502

Closed
d-kad wants to merge 2 commits intogambitproject:maint16_2from
d-kad:issue_499
Closed

Issue 499#502
d-kad wants to merge 2 commits intogambitproject:maint16_2from
d-kad:issue_499

Conversation

@d-kad
Copy link
Copy Markdown
Contributor

@d-kad d-kad commented Apr 4, 2025

Solves #499 by fixing the right order of source and destination nodes in copy_tree and move_tree methods.
Adds a test comparing subtrees after successful copy_tree.

@d-kad d-kad requested a review from tturocy April 4, 2025 10:26
@tturocy
Copy link
Copy Markdown
Member

tturocy commented Apr 4, 2025

I'm not following the intent of DeleteOutcome. The source node shouldn't be changed.. But further, DeleteOutcome does not just un-set the outcome at the node, it completely removes the outcome from the game - which we definitely don't want!

For this because it's a bug that's existed since 16.2, we want to base this on and merge this into maint16_2 - from there it will get merged forward into newer versions.

Finally, don't forget to add a ChangeLog entry (as this is a user-visible change) and mentioning the issue number.

@d-kad d-kad changed the base branch from master to maint16_2 April 8, 2025 16:04
@tturocy
Copy link
Copy Markdown
Member

tturocy commented Apr 9, 2025

Merged at:

@tturocy tturocy closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants