-
Notifications
You must be signed in to change notification settings - Fork 68
Fix (block styles): fix block error for divider and icon button #3583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Correct style-context: passing iconButtonStyles fixes provider/consumer mismatch
Switching to
withBlockStyleContext( iconButtonStyles )aligns the BlockStyleProvider with the same BlockStyleGenerator used byuseBlockCssGenerator(Line 52), which should resolve the reported block error. Inspector still receivesblockStylesfor UI variants, which is correct.Run a quick repo-wide check to ensure other blocks don’t still pass
blockStylesintowithBlockStyleContextand that each file’s HOC argument matches theuseBlockCssGenerator({ blockStyles: ... })value.🏁 Script executed:
Length of output: 778
🏁 Script executed:
Length of output: 22049
Update all blocks to use their specific style-context generators
The verification script uncovered that, beyond
icon-button, many blocks are still invokinginstead of their corresponding
<blockName>Styles. To avoid provider/consumer mismatches, each block’s HOC argument must match the identifier passed into itsuseBlockCssGenerator({ blockStyles: … }).Please update the following files accordingly (line numbers approximate):
countdownBlockStylestimelineBlockStylestextBlockStylesvideoPopupBlockStylesteamMemberBlockStylestabsBlockStylestestimonialBlockStylestableOfContentsBlockStylestabContentBlockStylespriceBlockStylessubtitleBlockStylesspacerBlockStylesmapBlockStylesseparatorBlockStylesprogressCircleBlockStylesprogressBarBlockStylespricingBoxBlockStylespostsBlockStylesnumberBoxBlockStylesnotificationBlockStylesiconBlockStylesimageBoxBlockStylesimageBlockStylesiconListBlockStylesiconLabelBlockStylesiconListItemBlockStylesheroBlockStyleshorizontalScrollerBlockStylesiconBoxBlockStylescardBlockStylesheadingBlockStylesfeatureGridBlockStylesfeatureBlockStylesdividerStyles)expandBlockStylescountUpBlockStylescolumnsBlockStylescallToActionBlockStylescolumnBlockStylescarouselBlockStylesbuttonGroupBlockStylesblockquoteBlockStylesaccordionBlockStylesExample diff for
countdown:🤖 Prompt for AI Agents