Skip to content

fix: remove design library pattern registration and only call remote get when design library is opened #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 4 commits into from
Aug 2, 2025
Merged

fix: remove design library pattern registration and only call remote get when design library is opened #3572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8265524
remove pattern registration
Aug 2, 2025
a2f083e
remove filters
kaeizen Aug 2, 2025
8185e3f
change transient name
kaeizen Aug 2, 2025
ae012c3
use the property cdnUrl
Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/design-library-list/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/* eslint-disable no-console */
import DEFAULT from './default.json'
import { settings, isPro } from 'stackable'
import {
settings, isPro, cdnUrl,
} from 'stackable'
import { parse, serialize } from '@wordpress/blocks'

const DEFAULT_CONTENT = { ...DEFAULT }
Expand Down Expand Up @@ -199,7 +201,7 @@ export const parseDisabledBlocks = parsedBlock => {
return { block, blocksForSubstitution }
}

const IMAGE_STORAGE = 'https://stackable-files.pages.dev/library-v4/images/'
const IMAGE_STORAGE = cdnUrl.replace( /\/$/, '' ) + '/library-v4/images/'

export const addPlaceholderForPostsBlock = ( content, postsPlaceholder, defaultValues ) => {
const remainingPosts = [ ...postsPlaceholder ]
Expand Down
236 changes: 17 additions & 219 deletions src/design-library/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ class Stackable_Design_Library {
public function __construct() {
add_action( 'rest_api_init', array( $this, 'register_route' ) );

add_filter( 'stackable_design_library_get_premium_designs', array( $this, 'get_designs_with_disabled_blocks' ) );
add_filter( 'stackable_design_library_get_premium_designs', array( $this, 'get_premium_designs' ) );
add_action( 'init', array( $this, 'register_design_pattern' ) );
add_action( 'stackable_delete_design_library_cache', array( $this, 'delete_cache_v3' ) );
}

Expand Down Expand Up @@ -109,23 +106,9 @@ public function delete_cache_v3() {
}

public function delete_cache() {
$designs = $this->get_design_library_from_cloud();

$library = $designs[ self::API_VERSION ];
foreach ( $library as $design_id => $design ) {
if ( WP_Block_Patterns_Registry::get_instance()->is_registered( 'stackable_' . $design_id ) ) {
$res = unregister_block_pattern( 'stackable_' . $design_id );
}

if ( WP_Block_Pattern_Categories_Registry::get_instance()->is_registered( 'stackable_' . $design[ 'category' ] ) ) {
$res = unregister_block_pattern_category( 'stackable_' . $design[ 'category' ] );
}
}
// Delete design library.
delete_transient( 'stackable_get_design_library_v4' );
delete_transient( 'stackable_get_design_library_json_v4' );

$this->register_design_pattern();
delete_transient( 'stackable_get_design_library_v4' );

do_action( 'stackable_delete_design_library_cache' );
}
Expand Down Expand Up @@ -240,12 +223,8 @@ public function get_design_library_image( $request ) {
), 200 );
}

public function filter_patterns( $pattern ) {
return strpos( $pattern[ 'name' ], 'stackable_' ) !== false;
}

public function get_design_library_from_cloud() {
$designs = get_transient( 'stackable_get_design_library_json_v4' );
$designs = get_transient( 'stackable_get_design_library_v4' );

// Fetch designs.
if ( empty( $designs ) ) {
Expand All @@ -262,8 +241,20 @@ public function get_design_library_from_cloud() {
);
} else {
$content_body = wp_remote_retrieve_body( $response );
$content = apply_filters( 'stackable_design_library_retreive_body', $content_body );
$content = json_decode( $content, true );
$designs = apply_filters( 'stackable_design_library_retreive_body', $content_body );
$designs = json_decode( $designs, true );

$content = array();
foreach ( $designs as $design_id => $design ) {
$content[ $design_id ] = array(
'title' => $design[ 'label' ],
'content' => $design[ 'template' ],
'category' => $design[ 'category' ],
'description' => $design[ 'description' ],
'plan' => $design[ 'plan' ],
'designId' => $design_id
);
}

// Add our error message so we can see it in the network tab.
if ( empty( $content ) ) {
Expand All @@ -280,40 +271,8 @@ public function get_design_library_from_cloud() {
// Allow deprecated code to fetch other designs
$designs = apply_filters( 'stackable_fetch_design_library', $designs );

// Cache results.
set_transient( 'stackable_get_design_library_json_v4', $designs, DAY_IN_SECONDS );
}

return apply_filters( 'stackable_design_library', $designs );
}

public function _get_design_library( $outside_init = false ) {
$designs = get_transient( 'stackable_get_design_library_v4' );
// Fetch designs.
if ( empty( $designs ) ) {
$designs = array();
$content = array();

$block_patterns = WP_Block_Patterns_Registry::get_instance()->get_all_registered( $outside_init );
foreach ( $block_patterns as $pattern ) {
if ( strpos( $pattern[ 'name' ], 'stackable_' ) !== false ) {
$pattern[ 'title' ] = str_replace( sprintf( __( 'Stackable ', STACKABLE_I18N ) ), '', $pattern[ 'title' ] );
$content[ $pattern[ 'designId' ] ] = $pattern;
}
}

// Get premium designs for v4
$content = apply_filters( 'stackable_design_library_get_premium_designs', $content );

// We add the latest designs in the `v4` area.
$designs[ self::API_VERSION ] = $content;

// Allow deprecated code to fetch other designs
$designs = apply_filters( 'stackable_fetch_design_library', $designs );

// Cache results.
set_transient( 'stackable_get_design_library_v4', $designs, DAY_IN_SECONDS );

}

return apply_filters( 'stackable_design_library', $designs );
Expand All @@ -328,170 +287,9 @@ public function get_design_library( $request ) {
$this->delete_cache();
}

return rest_ensure_response( $this->_get_design_library( $reset ) );
}

public function get_disabled_blocks() {
$disabled_blocks = get_option( 'stackable_block_states' );

if ( $disabled_blocks == false ) {
return false;
}

$disabled_blocks = array_filter( $disabled_blocks, function ( $block_state ) { return $block_state == 3; } );
if ( count( $disabled_blocks ) ) {
$disabled_blocks = array_keys( $disabled_blocks );
$disabled_blocks = array_map( function ( $block ) { return preg_quote( $block, '/' ); }, $disabled_blocks );
$disabled_blocks = '/' . implode( '|', $disabled_blocks ) . '/i';
return $disabled_blocks;
}

return false;
}

public function check_for_disabled_block( $design, $disabled_blocks ) {
if ( preg_match( $disabled_blocks, $design ) ) {
return true;
}

return false;
}

public function get_premium_designs( $content ) {
$designs = $this->get_design_library_from_cloud();

$library = $designs[ self::API_VERSION ];

$premium_designs = array();
foreach ( $library as $design_id => $design ) {
if ( $design[ 'plan' ] === 'premium' && STACKABLE_BUILD === 'premium' && sugb_fs()->can_use_premium_code() ) {
continue;
}

$premium_designs[ $design_id ] = array(
'title' => $design[ 'label' ],
'content' => $design[ 'template' ],
'category' => $design[ 'category' ],
'description' => $design[ 'description' ],
'plan' => $design[ 'plan' ],
'designId' => $design_id
);
}

$merged = array_merge( $content, $premium_designs );

uasort($merged, function( $design_1, $design_2 ) {
return strnatcmp( $design_1[ 'title' ], $design_2[ 'title' ] );
});

return $merged;
}

public function get_designs_with_disabled_blocks( $content ) {
$designs = $this->get_design_library_from_cloud();

$library = $designs[ self::API_VERSION ];

$designs_with_disabled = array();
foreach ( $library as $design_id => $design ) {
if ( isset( $content[ $design_id ] ) ) {
continue;
}

$designs_with_disabled[ $design_id ] = array(
'title' => $design[ 'label' ],
'content' => $design[ 'template' ],
'category' => $design[ 'category' ],
'description' => $design[ 'description' ],
'plan' => $design[ 'plan' ],
'designId' => $design_id,
);
}

$merged = array_merge( $content, $designs_with_disabled );

uasort($merged, function( $design_1, $design_2 ) {
return strnatcmp( $design_1[ 'title' ], $design_2[ 'title' ] );
});

return $merged;
}

public function get_category_kebab_case( $category ) {
$category = trim( strtolower( $category ) );
return preg_replace( '/[^a-z0-9-]+/', '-', $category );
}

public function get_template_with_placeholders( $template, $category ) {
if ( ! class_exists( 'Stackable_Design_Library_Placeholders' ) ) {
return $template;
}

$default_placeholders = Stackable_Design_Library_Placeholders::get_default();

if ( ! isset( $default_placeholders[ $category ] ) ) {
return $template;
}

foreach( $default_placeholders[ $category ] as $placeholder => $value ) {
if ( ! is_string( $value ) ) {
continue;
}
$template = str_replace( $placeholder, $value, $template );
}

return $template;
return rest_ensure_response( $this->get_design_library_from_cloud() );
}

public function register_design_pattern() {
$designs = $this->get_design_library_from_cloud();

$library = $designs[ self::API_VERSION ];

if ( ! $library ) {
return;
}


$disabled_blocks = $this->get_disabled_blocks();


if ( ! WP_Block_Pattern_Categories_Registry::get_instance()->is_registered( 'stackable' ) ) {
register_block_pattern_category( 'stackable', [
'label' => __( 'Stackable', STACKABLE_I18N ),
'description' => __( 'Patterns for Stackable Design Library', STACKABLE_I18N ),
] );
}

foreach ( $library as $design_id => $design ) {
if ( $design[ 'plan' ] === 'premium' && ( STACKABLE_BUILD === 'free' || ! sugb_fs()->can_use_premium_code() ) ) {
continue;
}

if ( $disabled_blocks ) {
$has_disabled = $this->check_for_disabled_block( $design[ 'template' ], $disabled_blocks );
if ( $has_disabled ) continue;
}

register_block_pattern_category( 'stackable_' . $this->get_category_kebab_case( $design[ 'category' ] ), [
'label' => sprintf( __( 'Stackable %s', STACKABLE_I18N ), $design[ 'category' ] ),
'description' => sprintf( __( '%s patterns for Stackable Design Library', STACKABLE_I18N ), $design[ 'category' ] ),
] );

register_block_pattern(
'stackable_' . $design_id,
array(
'title' => sprintf( __( 'Stackable %s', STACKABLE_I18N ), $design[ 'label' ] ),
'content' => $this->get_template_with_placeholders( $design[ 'template' ], $design[ 'category' ] ),
'categories' => array( 'stackable_' . $this->get_category_kebab_case( $design[ 'category' ] ), 'stackable' ), // used in Patterns
'category' => $design[ 'category' ], // used in Design Library
'description' => $design[ 'description' ],
'plan' => $design[ 'plan' ],
'designId' => $design_id
)
);
}
}

/**
* Gets the URL of the CDN where to load our design library data. When
Expand Down
Loading