Fix Shift key propagation and focused-pane Cmd routing#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes terminal key propagation so Shift-modified control keys are delivered correctly, and fixes focused-pane command routing so clipboard shortcuts target the pane the user actually focused.
Details
GhosttyNativeViewkeyboard handling to preserve Shift for control-text input paths (for exampleShift+EnterandShift+Tab) while still consuming modifiers for printable text when appropriate.GhosttyKeyEventTranslatorhelpers to centralize:flagsChangedpress/release action derivation from keycode + modifier stateconsumed_mods = GHOSTTY_MODS_NONE.SessionService.setFocusedPane(sessionID:controllerID)to:ensurePaneController(...).focus()), improvingCmd+C/Cmd+V/Cmd+Arouting in split panes.ShortcutRegistryTestscoverage for consumed-mod behavior and flagsChanged press/release behavior.SessionServiceTestscoverage for focused-pane terminal intent updates.Related Issues
Related to terminal modifier propagation and focused-pane clipboard routing regressions.
How to Validate
xcodebuild test -project idx0.xcodeproj -scheme idx0 -destination 'platform=macOS' -only-testing:idx0Tests/SessionServiceTests -only-testing:idx0Tests/ShortcutRegistryTestsTEST SUCCEEDED.Shift+EnterandShift+Tabare delivered reliably to the active terminal.Cmd+C,Cmd+V, andCmd+Aapply to the currently focused pane.Pre-Merge Checklist
lint-docscheck is greentestscheck is greenmaintainabilityresult reviewed (phase 1 report-only)