Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate
Settings...entries in the macOS app menu by removing the extra Settings scene menu contribution and keeping a single settings command wired to IDX0's inline settings UI.Details
Settings { ... }scene fromidx0/App/idx0App.swift.CommandGroup(replacing: .appSettings)with the existingSettings...action and keyboard shortcut (.openSettings).Settings...item appears in the app menu while preserving the existing inline settings flow.Related Issues
Closes #15
How to Validate
xcodebuild -project idx0.xcodeproj -scheme idx0 -destination 'platform=macOS' build** BUILD SUCCEEDED **IDX0in the menu bar).Settings...item.Settings...and verify the inline settings view opens as before.Pre-Merge Checklist
xcodebuild/ Xcode)