feat(browser): add first-use browser control opt-in and setup#14
Open
feat(browser): add first-use browser control opt-in and setup#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a first-use browser-control consent flow and app-managed setup pipeline so browser surfaces can be opened immediately while enabling MCP-based browser automation for supported installed CLIs.
Details
BrowserControlConsentstate to app settings (undecided/enabled/declined) with schema migration defaults.SessionService:requestToggleBrowserSplit(...)requestOpenURLInSplit(...)requestAddNiriBrowserTile(...)Not nowstoresdeclinedand replays queued action(s).Enable Browser Controlruns setup; on success storesenabledand replays queued action(s).BrowserControlConsentSheetto main window sheet stack.BrowserControlSetupServiceactor:@playwright/mcp@0.0.68under app support (.../idx0/browser-control/)codex,claude,gemini) using each CLI’s MCP commandsidx0-browserlocal MCP entry into isolatedxdg-config/opencode/opencode.jsonwithout clobbering existing config.Related Issues
N/A
How to Validate
xcodebuild -project idx0.xcodeproj -scheme idx0 -destination 'platform=macOS' test -only-testing:idx0Tests/AppSettingsKeyboardTests -only-testing:idx0Tests/OpenCodeRuntimeTests -only-testing:idx0Tests/BrowserControlSetupServiceTests -only-testing:idx0Tests/SessionServiceTests/testBrowserConsentPromptAppearsAndQueuesOnFirstBrowserOpen -only-testing:idx0Tests/SessionServiceTests/testBrowserConsentDeclineReplaysQueuedIntentAndSuppressesFuturePrompt -only-testing:idx0Tests/SessionServiceTests/testBrowserConsentEnableSuccessStoresEnabledAndReplaysQueuedIntent -only-testing:idx0Tests/SessionServiceTests/testBrowserConsentEnableFailureKeepsUndecidedShowsErrorAndStillReplaysIntent -only-testing:idx0Tests/SessionServiceTests/testBrowserConsentGateCoversNiriBrowserTileAndClipboardOpenxcodebuild -project idx0.xcodeproj -scheme idx0 -destination 'platform=macOS' testSessionServiceTests/testNiriColumnResizePersistsPreferredWidths()SessionServiceTests/testNiriDefaultTileSizesApplyOnlyToNewTiles()SessionServiceTests/testNiriItemResizePersistsPreferredHeights()Not nowstill opens requested browser surface and suppresses future prompts.Pre-Merge Checklist
xcodebuild/ Xcode)