Fixes for non-continuous calibration #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, I'll see if i can test this with both continuous and regular on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains fixes for the following issues happening with non-continuous calibration:
motoc monitorshows zeroes for tracking origin offsetsmotoc continuetwice or more stacks the applied offset, effectively sending one of the tracking origins away.motoc calibratesaves pre-calibration tracking origin transform, which is typically identityWith these changes I can stick a
motoc continueinto my Envision plugin list and have it restore calibration successfully on launch. Subsequent calibrations are stored and restored correctly too.Note that I haven't tested continuous calibration with these changes, but I believe I didn't touch the code path used in it.