Add Phinch as an external display application. #2069
Merged
martenson merged 1 commit intogalaxyproject:devfrom Apr 4, 2016
Merged
Add Phinch as an external display application. #2069martenson merged 1 commit intogalaxyproject:devfrom
martenson merged 1 commit intogalaxyproject:devfrom
Conversation
… personal copy of Phinch, since it requires PitchInteractiveInc/Phinch#54
Member
|
I'm -.5 on copying over a sample file with the URL http://www.bx.psu.edu/~dan/Phinch/ encoded in it - it means deployments won't get the config they want with a real URL someday if we want to invest in this (phinch.galaxyproject.org or something) or if they fix Phinch upstream. However, I'll merge this myself if you merge #2070 or something like this so we don't have to write this loc file. |
Member
|
Can we provide the configs directly to Main (which is probably the target of this change) and provide sample config once Phinch updates or once we start our Phinch service? |
Member
|
I'm 👍 on this as is since #2070 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently linking to a personal copy of Phinch, since it requires upstream enhancements to allow loading via a URL: PitchInteractiveInc/Phinch#54