Skip to content

Add Phinch as an external display application. #2069

Merged
martenson merged 1 commit intogalaxyproject:devfrom
blankenberg:biom-phinch
Apr 4, 2016
Merged

Add Phinch as an external display application. #2069
martenson merged 1 commit intogalaxyproject:devfrom
blankenberg:biom-phinch

Conversation

@blankenberg
Copy link
Member

Currently linking to a personal copy of Phinch, since it requires upstream enhancements to allow loading via a URL: PitchInteractiveInc/Phinch#54

@jmchilton
Copy link
Member

I'm -.5 on copying over a sample file with the URL http://www.bx.psu.edu/~dan/Phinch/ encoded in it - it means deployments won't get the config they want with a real URL someday if we want to invest in this (phinch.galaxyproject.org or something) or if they fix Phinch upstream. However, I'll merge this myself if you merge #2070 or something like this so we don't have to write this loc file.

@martenson
Copy link
Member

Can we provide the configs directly to Main (which is probably the target of this change) and provide sample config once Phinch updates or once we start our Phinch service?

@jmchilton
Copy link
Member

I'm 👍 on this as is since #2070 was merged.

@martenson martenson merged commit e7d4bc3 into galaxyproject:dev Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants