Skip to content

Fix device pixel ratio for tiff viewer #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 2 commits into from
Mar 12, 2026
Merged

Fix device pixel ratio for tiff viewer #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b178f
Enforces consistent trailing comma usage
davelopez Mar 12, 2026
753ecea
Removes device pixel ratio scaling from canvas
davelopez Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions packages/tiffviewer/src/ui-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class UIManager {
constructor(
tiffService: TIFFService,
paletteManager: PaletteManager,
appElement: HTMLElement
appElement: HTMLElement,
) {
this.tiffService = tiffService;
this.paletteManager = paletteManager;
Expand Down Expand Up @@ -75,7 +75,7 @@ export class UIManager {
const rgba = new Uint8ClampedArray(width * height * 4);
if (samples === 1) {
const palette = this.paletteManager.getPalette(
this.paletteManager.getCurrentPalette()
this.paletteManager.getCurrentPalette(),
);
for (let i = 0; i < width * height; i++) {
const v = data[i];
Expand All @@ -96,10 +96,8 @@ export class UIManager {
console.warn(`Unsupported sample format with ${samples} channels`);
return;
}
const dpr = window.devicePixelRatio || 1;
this.canvas.width = width * dpr;
this.canvas.height = height * dpr;
context.scale(dpr, dpr);
this.canvas.width = width;
this.canvas.height = height;
this.canvas.style.width = `${width}px`;
this.canvas.style.height = `${height}px`;
const imageData = new ImageData(rgba, width, height);
Expand Down Expand Up @@ -172,7 +170,7 @@ export class UIManager {
// Palette panel (SVG)
const palettePanelBtn = document.createElement("button");
palettePanelBtn.appendChild(
this.createIcon("palette", "Show Palette Selector")
this.createIcon("palette", "Show Palette Selector"),
);
palettePanelBtn.title = "Show Palette Selector";
palettePanelBtn.type = "button";
Expand Down Expand Up @@ -312,7 +310,7 @@ export class UIManager {
const rows = Object.entries(tags)
.map(
([key, value]) =>
`<tr><td class='info-table-key'>${key}</td><td class='info-table-value'>${value}</td></tr>`
`<tr><td class='info-table-key'>${key}</td><td class='info-table-value'>${value}</td></tr>`,
)
.join("");
return `
Expand Down Expand Up @@ -373,8 +371,8 @@ export class UIManager {
const container = this.canvas.parentElement as HTMLElement;
if (!container) return;
const containerRect = container.getBoundingClientRect();
const width = this.canvas.width / (window.devicePixelRatio || 1);
const height = this.canvas.height / (window.devicePixelRatio || 1);
const width = this.canvas.width;
const height = this.canvas.height;
let useScale = scale;
if (isNaN(useScale) || useScale <= 0) {
useScale = this.panzoom.getScale() || 1;
Expand All @@ -393,8 +391,8 @@ export class UIManager {
const container = this.canvas.parentElement as HTMLElement;
if (!container) return;
const containerRect = container.getBoundingClientRect();
const width = this.canvas.width / (window.devicePixelRatio || 1);
const height = this.canvas.height / (window.devicePixelRatio || 1);
const width = this.canvas.width;
const height = this.canvas.height;
const scaleX = containerRect.width / width;
const scaleY = containerRect.height / height;
const scale = Math.min(scaleX, scaleY);
Expand Down
Loading