Skip to content

[locuszoom] Fix plot height #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guerler merged 2 commits into from
Jan 30, 2026
Merged

[locuszoom] Fix plot height #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d6bc5
Fix plot height
guerler Jan 30, 2026
aa3bfa2
Add test screenshot
guerler Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/locuszoom/src/Plugin.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ watch(
class="absolute mt-1 p-3 border bg-red-100 text-red-700 text-sm rounded opacity-95 w-[100%]">
{{ errorMessage }}
</div>
<div id="lz-plot" class="h-100"></div>
<div id="lz-plot" class="h-full"></div>
</template>

<style>
Expand Down
Binary file added packages/locuszoom/test-data/test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/locuszoom/test.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
const BGZIP = readFileSync(resolve(__dirname, "test-data/test.gwas_bgzip"));
const TABIX = readFileSync(resolve(__dirname, "test-data/test.gwas_bgzip.tbi"));

const maxDiffPixelRatio = 0.06;

function fulfillBinary(route, data) {
const rangeHeader = route.request().headers()["range"];
const match = rangeHeader?.match(/bytes=(\d+)-(\d+)/);
Expand Down Expand Up @@ -58,4 +60,5 @@ test("Run plot", async ({ page }) => {
await expect(PHENO_STAT_TO_CLICK).toBeVisible();
await page.getByRole("button", { name: "×" }).click();
await expect(PHENO_STAT_TO_CLICK).toBeHidden();
await expect(page).toHaveScreenshot("test.png", { maxDiffPixelRatio });
});