Skip to content

Fix sync-less doorbell discovery on shared networks#1

Open
gal-nir wants to merge 2 commits intodevfrom
feature/doorbell-homescreen-fallback
Open

Fix sync-less doorbell discovery on shared networks#1
gal-nir wants to merge 2 commits intodevfrom
feature/doorbell-homescreen-fallback

Conversation

@gal-nir
Copy link
Copy Markdown
Owner

@gal-nir gal-nir commented Mar 26, 2026

Summary

  • Fixes discovery for sync-less doorbells when a sync-less mini exists on the same network ID.
  • Uses homescreen parsing helpers for minis/doorbells (including alternate doorbell payload keys like lotus).
  • Only treats a device as "attached to sync module" when a real sync module exists for that network.
  • Prevents camera-list merge drops when a network is absent from camera/usage.
  • Adds regression tests for alternate homescreen keys and sync-less doorbell behavior.

Reproduction

  • Account with:
    • Blink Mini (sync-less)
    • Blink Doorbell (sync-less)
  • Both appear in homescreen.
  • camera/usage returns empty cameras list for that network.

Before

  • Only mini appeared in blink.cameras.
  • Doorbell was skipped.

After

  • Both mini and doorbell appear in blink.cameras.
  • Doorbell supports existing BlinkLotus flow correctly.

Test plan

  • Existing device listing script shows both devices.
  • Doorbell appears under cameras and doorbell listing.
  • New/updated unit tests cover:
    • alternate homescreen key (lotus)
    • sync-less doorbell with empty camera/usage
    • attached-to-sync behavior requiring sync_modules presence.

modified:   blinkpy/sync_module.py
modified:   tests/test_blinkpy.py
modified:   tests/test_sync_module.py
@gal-nir gal-nir force-pushed the feature/doorbell-homescreen-fallback branch from 269ef30 to c25e3eb Compare March 29, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant