fix: handle JSONDecodeError in _handle_response to prevent crashes#85
Merged
gagebenne merged 3 commits intogagebenne:mainfrom Jul 26, 2025
Merged
fix: handle JSONDecodeError in _handle_response to prevent crashes#85gagebenne merged 3 commits intogagebenne:mainfrom
gagebenne merged 3 commits intogagebenne:mainfrom
Conversation
- Add ServerResponseError and ServerResponseErrorEnum for invalid JSON responses - Wrap response.json() in try/except to catch JSONDecodeError - Return ServerResponseError instead of crashing when API returns empty/malformed JSON - Fixes gagebenne#62: erratic JSONDecodeError crashes during API polling This prevents application crashes when Dexcom Share API returns empty or invalid JSON responses, allowing graceful error handling and retry logic
gagebenne
reviewed
Jul 20, 2025
Owner
|
@alexaustin007 Nice. Thanks for the contribution!!! Feel free to give this another once over, otherwise I'll go ahead and merge it. |
Contributor
Author
|
@gagebenne LGTM - please go ahead, happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents application crashes when Dexcom Share API returns empty or invalid JSON responses, allowing graceful error handling and retry logic