Skip to content

Test corrections #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YoyoCaleb wants to merge 3 commits into
base: Dev
Choose a base branch
from
Open

Test corrections #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b837b7
Changes to AllowedActionTaken, BudgetCode, and Contact Test
YoyoCaleb Jan 6, 2026
8049a9b
Updated ContactType Test. Removed redundant test in EventType
YoyoCaleb Jan 6, 2026
ffbc76e
Changes FacilityType, ParcelType, Phone, and Score Test
YoyoCaleb Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/FMS.Infrastructure.Tests/AllowedActionTakenRepositoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public async Task GetAllowedActionTakenByAATIdAsync_ReturnsNull_WhenIdDoesNotExi

// GetAllowedActionTakenListAsync
[Test]
public async Task GetAllowedActionTakenListAsync_ReturnsAllContactType_WhenEventTypeIdIsValid()
public async Task GetAllowedActionTakenListAsync_ReturnsAllAllowedActionTypes_WhenEventTypeIdIsValid()
{
var existingEventType = new EventType { Name = "VALID_ET", Id = Guid.NewGuid()};

Expand Down
55 changes: 27 additions & 28 deletions tests/FMS.Infrastructure.Tests/BudgetCodeRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ public void SetUp()
_context.BudgetCodes.Add(new BudgetCode
{
Id = Guid.NewGuid(),
Code = "TEST",
Name = "Test Budget Code",
Code = "VALID_CODE",
Name = "VALID_NAME",
Active = true
});
_context.SaveChanges();
Expand All @@ -59,15 +59,15 @@ public void Dispose()
}
}

// Test for GetBudgetCodeAsync method
// GetBudgetCodeAsync
[Test]
public async Task GetBudgetCodeAsync_ReturnsCorrectBudgetCode_WhenIdIsValid()
{
var budgetCode = new BudgetCode
{
Id = Guid.NewGuid(),
Code = "VALID_CODE",
Name = "Valid Name",
Name = "VALID_NAME",
Active = true
};
_context.BudgetCodes.Add(budgetCode);
Expand All @@ -77,7 +77,7 @@ public async Task GetBudgetCodeAsync_ReturnsCorrectBudgetCode_WhenIdIsValid()

result.Should().NotBeNull();
result.Code.Should().Be("VALID_CODE");
result.Name.Should().Be("Valid Name");
result.Name.Should().Be("VALID_NAME");
}

[Test]
Expand All @@ -87,7 +87,7 @@ public async Task GetBudgetCodeAsync_ReturnsNull_WhenIdIsInvalid()
result.Should().BeNull();
}

// Test for GetBudgetCodeListAsync method
// GetBudgetCodeListAsync
[Test]
public async Task GetBudgetCodeListAsync_ReturnsAllBudgetCodes()
{
Expand All @@ -106,14 +106,14 @@ public async Task GetBudgetCodeListAsync_ReturnsAllBudgetCodes()
result.Count.Should().Be(3); // Including the initial seed data
}

// Test for CreateBudgetCodeAsync method
// CreateBudgetCodeAsync
[Test]
public async Task CreateBudgetCodeAsync_Succeeds_WhenDataIsValid()
{
var budgetCodeCreateDto = new BudgetCodeCreateDto
{
Code = "NEW_CODE",
Name = "New Budget Code",
Name = "NEW_NAME",
OrganizationNumber = "ORG123",
ProjectNumber = "PROJ456"
};
Expand All @@ -123,71 +123,71 @@ public async Task CreateBudgetCodeAsync_Succeeds_WhenDataIsValid()

createdBudgetCode.Should().NotBeNull();
createdBudgetCode.Code.Should().Be("NEW_CODE");
createdBudgetCode.Name.Should().Be("New Budget Code");
createdBudgetCode.Name.Should().Be("NEW_NAME");
}

[Test]
public void CreateBudgetCodeAsync_ThrowsException_WhenCodeAlreadyExists()
{
var budgetCodeCreateDto = new BudgetCodeCreateDto
{
Code = "TEST",
Name = "Duplicate Code",
Code = "VALID_CODE", // Name already exists from seed data
Name = "NEW_NAME",
OrganizationNumber = "ORG789",
ProjectNumber = "PROJ101"
};

Func<Task> action = async () => await _repository.CreateBudgetCodeAsync(budgetCodeCreateDto);
action.Should().ThrowAsync<ArgumentException>().WithMessage("Budget Code TEST already exists.");
action.Should().ThrowAsync<ArgumentException>();
}

[Test]
public void CreateBudgetCodeAsync_ThrowsException_WhenNameAlreadyExists()
{
var budgetCodeCreateDto = new BudgetCodeCreateDto
{
Code = "UNIQUE_CODE",
Name = "Test Budget Code", // Name already exists from seed data
Code = "NEW_CODE",
Name = "VALID_NAME", // Name already exists from seed data
OrganizationNumber = "ORG789",
ProjectNumber = "PROJ101"
};

Func<Task> action = async () => await _repository.CreateBudgetCodeAsync(budgetCodeCreateDto);
action.Should().ThrowAsync<ArgumentException>().WithMessage("Budget Code Name Test Budget Code already exists.");
action.Should().ThrowAsync<ArgumentException>();
}

// Test for UpdateBudgetCodeAsync method
// UpdateBudgetCodeAsync
[Test]
public async Task UpdateBudgetCodeAsync_Succeeds_WhenDataIsValid()
{
var existingBudgetCode = await _context.BudgetCodes.FirstAsync();
var budgetCodeEditDto = new BudgetCodeEditDto(existingBudgetCode)
{
Code = "UPDATED_CODE",
Name = "Updated Name"
Name = "UPDATED_NAME"
};

await _repository.UpdateBudgetCodeAsync(existingBudgetCode.Id, budgetCodeEditDto);
var updatedBudgetCode = await _context.BudgetCodes.FindAsync(existingBudgetCode.Id);

updatedBudgetCode.Code.Should().Be("UPDATED_CODE");
updatedBudgetCode.Name.Should().Be("Updated Name");
updatedBudgetCode.Name.Should().Be("UPDATED_NAME");
}

[Test]
public void UpdateBudgetCodeAsync_ThrowsException_WhenIdDoesNotExist()
{
var budgetCodeEditDto = new BudgetCodeEditDto
{
Code = "NON_EXISTENT",
Name = "Non-existent"
Code = "INVALID_CODE",
Name = "VALID_NAME"
};

Func<Task> action = async () => await _repository.UpdateBudgetCodeAsync(Guid.NewGuid(), budgetCodeEditDto);
action.Should().ThrowAsync<ArgumentException>().WithMessage("Budget Code ID not found.");
action.Should().ThrowAsync<ArgumentException>();
}

// Test for UpdateBudgetCodeStatusAsync method
// UpdateBudgetCodeStatusAsync
[Test]
public async Task UpdateBudgetCodeStatusAsync_UpdatesStatusCorrectly()
{
Expand All @@ -196,7 +196,7 @@ public async Task UpdateBudgetCodeStatusAsync_UpdatesStatusCorrectly()
{
Id = Guid.NewGuid(),
Code = "UPDATE_TEST",
Name = "Update Test Budget Code",
Name = "UPDATE_NAME",
Active = true
};
_context.BudgetCodes.Add(budgetCode);
Expand Down Expand Up @@ -230,7 +230,7 @@ public async Task UpdateBudgetCodeAsync_ThrowsArgumentNullException_WhenBudgetCo
Func<Task> act = async () => await _repository.UpdateBudgetCodeAsync(validId, null);

// Assert
await act.Should().ThrowAsync<ArgumentNullException>().WithMessage("*budgetCodeUpdates*");
await act.Should().ThrowAsync<ArgumentNullException>();
}
[Test]
public async Task CreateBudgetCodeAsync_ThrowsArgumentException_WhenCodeOrNameAlreadyExists()
Expand All @@ -240,7 +240,7 @@ public async Task CreateBudgetCodeAsync_ThrowsArgumentException_WhenCodeOrNameAl
{
Id = Guid.NewGuid(),
Code = "DUPLICATE_CODE",
Name = "Duplicate Budget Code",
Name = "DUPLICATE_NAME",
Active = true
};
_context.BudgetCodes.Add(existingBudgetCode);
Expand All @@ -250,15 +250,14 @@ public async Task CreateBudgetCodeAsync_ThrowsArgumentException_WhenCodeOrNameAl
var newBudgetCode = new BudgetCodeCreateDto
{
Code = "DUPLICATE_CODE", // Same code as the existing one
Name = "Duplicate Budget Code" // Same name as the existing one
Name = "DUPLICATE_NAME" // Same name as the existing one
};

// Act
Func<Task> act = async () => await _repository.CreateBudgetCodeAsync(newBudgetCode);

// Assert
await act.Should().ThrowAsync<ArgumentException>()
.WithMessage("Budget Code DUPLICATE_CODE already exists.");
await act.Should().ThrowAsync<ArgumentException>();
}
}
}
6 changes: 2 additions & 4 deletions tests/FMS.Infrastructure.Tests/ContactRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,7 @@ public async Task UpdateContactsAsync_ThrowsInvalidOperationException_WhenIdDoes

var action = async () => await _repository.UpdateContactAsync(invalidId, updateDto);

await action.Should().ThrowAsync<InvalidOperationException>()
.WithMessage("Contact with ID " + invalidId + " does not exist.");
await action.Should().ThrowAsync<InvalidOperationException>();
}

// UpdateContactActiveAsync
Expand All @@ -251,8 +250,7 @@ public async Task UpdateContactActiveAsync_ThrowsInvalidOperationException_WhenI
{
var invalidId = Guid.NewGuid();
var action = async () => await _repository.UpdateContactActiveAsync(invalidId, false);
await action.Should().ThrowAsync<InvalidOperationException>()
.WithMessage("Contact with ID " + invalidId + " does not exist.");
await action.Should().ThrowAsync<InvalidOperationException>();
}
}
}
24 changes: 12 additions & 12 deletions tests/FMS.Infrastructure.Tests/ContactTypeRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void SetUp()
_context.ContactTypes.Add(new ContactType
{
Id = Guid.NewGuid(),
Name = "Contact Type",
Name = "VALID_NAME",
Active = true
});
_context.SaveChanges();
Expand All @@ -58,14 +58,14 @@ public void Dispose()

//ContactTypeExistAsync
[Test]
public async Task ContactTypeExistAsync_ReturnTrue_ContactTypeExist()
public async Task ContactTypeExistAsync_ReturnTrue_WhenContactTypeExist()
{
var existingCT = await _context.ContactTypes.Select(ft => ft.Id).FirstAsync();
var results = await _repository.ContactTypeExistsAsync(existingCT);
results.Should().BeTrue();
}
[Test]
public async Task ContactTypeExistAsync_ReturnFalse_ContactTypeDoesNotExist()
public async Task ContactTypeExistAsync_ReturnFalse_WhenContactTypeDoesNotExist()
{
var nonExistingCT = Guid.NewGuid();
var results = await _repository.ContactTypeExistsAsync(nonExistingCT);
Expand All @@ -85,7 +85,7 @@ public async Task GetContactTypeByIdAsync_WhenIdExist()
result.Name.Should().Be(existingCT.Name);
}
[Test]
public async Task GetContactTypeByIdAsync_WhenIdDoesNotExist_ReturnsNull()
public async Task GetContactTypeByIdAsync_ReturnsNull_WhenIdDoesNotExist()
{
var nonExistingId = Guid.NewGuid();
var result = await _repository.GetContactTypeByIdAsync(nonExistingId);
Expand All @@ -105,13 +105,13 @@ public async Task GetContactTypeListAsync_ReturnsAllContactTypes()
[Test]
public async Task CreateContactTypeAsync_CreateNewContactType_WhenDataIsValid()
{
var dto = new ContactTypeCreateDto { Name = "UniqueName" };
var dto = new ContactTypeCreateDto { Name = "NEW_NAME" };

var newId = await _repository.CreateContactTypeAsync(dto);
var createdContactType = await _context.ContactTypes.FindAsync(newId);

createdContactType.Should().NotBeNull();
createdContactType.Name.Should().Be("UniqueName");
createdContactType.Name.Should().Be("NEW_NAME");
}
/*[Test]
public async Task CreateContactTypeAsync_ThrowsArgumentException_WhereNameAlreadyExist()
Expand All @@ -130,15 +130,15 @@ public async Task CreateContactTypeAsync_ThrowsArgumentException_WhereNameAlread
[Test]
public async Task UpdateContactTypeAsync_UpdatesExistingContactType_WhenDataIsValid()
{
var existingContactType = new ContactType { Id = Guid.NewGuid(), Name = "OriginalName" };
var existingContactType = new ContactType { Id = Guid.NewGuid(), Name = "VALID_NAME" };
_context.ContactTypes.Add(existingContactType);
await _context.SaveChangesAsync();

var updateDto = new ContactTypeEditDto { Name = "UpdatedName" };
var updateDto = new ContactTypeEditDto { Name = "UPDATED_NAME" };
await _repository.UpdateContactTypeAsync(existingContactType.Id, updateDto);

var updatedContactType = await _context.ContactTypes.FindAsync(existingContactType.Id);
updatedContactType.Name.Should().Be("UpdatedName");
updatedContactType.Name.Should().Be("UPDATED_NAME");
}
[Test]
public async Task UpdateContactTypeAsync_ThrowsArgumentException_WhenIdDoesNotExist()
Expand All @@ -147,14 +147,14 @@ public async Task UpdateContactTypeAsync_ThrowsArgumentException_WhenIdDoesNotEx
var updateDto = new ContactTypeEditDto { Name = "NON_EXISTENT" };

Func<Task> action = async () => await _repository.UpdateContactTypeAsync(invalidId, updateDto);
await action.Should().ThrowAsync<ArgumentException>().WithMessage("Contact Type ID not found. (Parameter 'id')");
await action.Should().ThrowAsync<ArgumentException>();
}

//UpdateContactTypeStatusAsync
[Test]
public async Task UpdateContactTypeStatusAsync_UpdatesStatusCorrectly()
{
var contactType = new ContactType { Id = Guid.NewGuid(), Name = "StatusTest", Active = true };
var contactType = new ContactType { Id = Guid.NewGuid(), Name = "VALID_NAME", Active = true };
_context.ContactTypes.Add(contactType);
await _context.SaveChangesAsync();

Expand All @@ -168,7 +168,7 @@ public async Task UpdateContactTypeStatusAsync_UpdatesStatusCorrectly()
public async Task UpdateContactTypeStatusAsync_ThrowsArgumentException_WhenIdDoesNotExist()
{
Func<Task> action = async () => await _repository.UpdateContactTypeStatusAsync(Guid.NewGuid(), false);
await action.Should().ThrowAsync<ArgumentException>().WithMessage("Contact Type ID not found");
await action.Should().ThrowAsync<ArgumentException>();
}
}
}
30 changes: 2 additions & 28 deletions tests/FMS.Infrastructure.Tests/EventTypeRepositoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,15 @@ public void Dispose()

// EventTypeExistAsync
[Test]
public async Task EventTypeExistAsync_ReturnsTrue_EventTypeExist()
public async Task EventTypeExistAsync_ReturnsTrue_WhenEventTypeExist()
{
var existingET = await _context.EventTypes.Select(ft => ft.Id).FirstAsync();
var results = await _repository.EventTypeExistsAsync(existingET);
results.Should().BeTrue();
}

[Test]
public async Task EventTypeExistAsync_ReturnsFalse_EventTypeDoesNotExist()
public async Task EventTypeExistAsync_ReturnsFalse_WhenEventTypeDoesNotExist()
{
var nonExistingET = Guid.NewGuid();
var results = await _repository.EventTypeExistsAsync(nonExistingET);
Expand Down Expand Up @@ -103,11 +103,7 @@ public async Task EventTypeNameExistAsync_ReturnsFalse_EventTypeNameDoesNotExist
results.Should().BeFalse();
}


// GetEventTypeByIdAsync


// GetEventTypeNameAsync
[Test]
public async Task GetEventTypeByIdAsync_ReturnsEventTypeEditEto_WhenIdExist()
{
Expand All @@ -128,25 +124,6 @@ public async Task GetEventTypeByIdAsync_ReturnsNull_WhenIdDoesNotExist()
results.Should().BeNull();
}

// GetEventTypeNameAsync
[Test]
public async Task GetEventTypeNameAsyncReturnsEventTypeNameWhenIdExist()
{
var existingET = await _context.EventTypes.FirstAsync();

var results = await _repository.GetEventTypeNameAsync(existingET.Id);

results.Should().Be(existingET.Name);
}
[Test]
public async Task GetEventTypeNameAsyncReturnsNullWhenIdDoesNotExist()
{
var nonExistingId = Guid.NewGuid();
var results = await _repository.GetEventTypeNameAsync(nonExistingId);

results.Should().BeNull();
}

// GetEventTypeNameAsync
[Test]
public async Task GetEventTypeNameAsync_ReturnsEventTypeName_WhenIdExist()
Expand Down Expand Up @@ -177,9 +154,6 @@ public async Task GetEventTypeListAsync_ReturnsAllEventTypes()
results.Should().NotBeNullOrEmpty();
}




// CreateEventTypeAsync
[Test]
public async Task CreateEventTypeAsync_CreatesEventType_WhenDataIsValid()
Expand Down
Loading
Loading