Skip to content

Remove dynamic loading and XML configuration and add CLI parameters #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
naegelejd wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Remove dynamic loading and XML configuration and add CLI parameters #13

naegelejd wants to merge 21 commits into from

Conversation

@naegelejd
Copy link
Member

@naegelejd naegelejd commented Feb 19, 2025

This PR:

  • Removes runtime loading of dynamic libraries
  • Removes XML configurations
  • Removes all MR-specific code from the Core library
  • Removes much dead code
  • Introduces Pipeline and Builders for constructing a reconstruction chain
  • Introduces Node-level CLI parameters for every step of the reconstruction chain

Test it out with:

  • pingvin -l: List available pipelines
  • mrd_phantom | pingvin default > reconstructed.mrd: Basic recon

Closes #6

naegelejd and others added 21 commits February 6, 2025 16:49
@naegelejd
Remove old Gadget and GadgetContainerMessage
fa5144d
@naegelejd
Add emperor, a new prototype CLI
be0deb3
@naegelejd
Implement default.xml in emperor
bc90bdb
@naegelejd
Disable runtime library loading
82ccdd9
@naegelejd
Switch to Pipeline::Builder approach
b5d1941
@naegelejd
Remove MRD Header from GenericChannelGadget
f464c0f
@naegelejd
Update half of mri_core Gadgets
47afe3d
@naegelejd
Update EPI gadgets and implement epi.xml chain
9b91463
@naegelejd
Update remaining mri_core gadgets
4756845
@naegelejd
Add parallel Pipeline streams. Update grappa gadgets.
f32be35
@naegelejd
Update all generic recon gadgets
37e7367
@naegelejd
Update CMR and all remaining gadgets
8632362
@naegelejd
Update all end-to-end tests
b332059
@naegelejd
Remove unused code
de9ffe0
@naegelejd
Remove unused ErrorHandler
fb5e85f
@naegelejd
Replace the Processable interface with Nodes
b4d8daa
@naegelejd
Move Pipeline and Builders to core/
dca7eea
@naegelejd
Remove all MR-specific code from the core library
67c80ca
@naegelejd
Remove old XML config files
38d6751
@naegelejd
Fix CI issues
765035a
@naegelejd
Disable GPU pipelines in nocuda docker build
e1ffe33
@naegelejd naegelejd requested a review from hansenms February 24, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hansenms hansenms Awaiting requested review from hansenms

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove XML configurations and runtime linking

2 participants

@naegelejd