Upgrade all remaining gadgets to ChannelGadgets #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansenms
previously approved these changes
Feb 5, 2025
Member
hansenms
left a comment
hansenms
left a comment
There was a problem hiding this comment.
Looks good. I think we should rename Gadget to Node. And all the logging macros should also be renamed.....and perhaps we should replace this with some proper logging library so that we can get structured logs when it makes sense. But all those things should not be this PR.
| mkdir build && \ | ||
| cd build && \ | ||
| cmake ../ -GNinja -DUSE_MKL=ON -DCMAKE_INSTALL_PREFIX=/opt/package && \ | ||
| ninja && \ |
Member
Author
There was a problem hiding this comment.
Agreed. I was trying to "debug" why compilation in the build pipeline seems so slow, possibly even single-threaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All remaining compiled Gadgets have been upgraded to derive from
ChannelGadget, and the oldGadgetclass and relatedGadgetContainerMessagecode has been removed.Closes #8.