Skip to content

Fixed camera preview scale. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ct7ct7ct7 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed camera preview scale. #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25f21d0
Update pubspec.yaml
kArtDevelopers May 3, 2022
661c52a
Merge pull request #1 from kArtDevelopers/kArtDevelopers-patch-1
kArtDevelopers May 3, 2022
eb84d48
Update pubspec.yaml
kArtDevelopers May 4, 2022
e20a603
Update pubspec.yaml
kArtDevelopers May 4, 2022
c708e22
upgrade libs.
ct7ct7ct7 Jun 10, 2022
6805b7c
fix camera preview scale.
ct7ct7ct7 Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/src/presentation/controller/camera_camera_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ class CameraCameraController {
late CameraController _controller;

final statusNotifier = ValueNotifier<CameraCameraStatus>(CameraCameraEmpty());

CameraCameraStatus get status => statusNotifier.value;

set status(CameraCameraStatus status) => statusNotifier.value = status;

CameraCameraController({
Expand All @@ -25,8 +27,7 @@ class CameraCameraController {
required this.onPath,
this.enableAudio = false,
}) {
_controller = CameraController(cameraDescription, resolutionPreset,
enableAudio: enableAudio);
_controller = CameraController(cameraDescription, resolutionPreset, enableAudio: enableAudio);
}

void init() async {
Expand Down Expand Up @@ -99,8 +100,7 @@ class CameraCameraController {
void setZoomLevel(double zoom) async {
if (zoom != 1) {
var cameraZoom = double.parse(((zoom)).toStringAsFixed(1));
if (cameraZoom >= status.camera.minZoom &&
cameraZoom <= status.camera.maxZoom) {
if (cameraZoom >= status.camera.minZoom && cameraZoom <= status.camera.maxZoom) {
final camera = status.camera.copyWith(zoom: cameraZoom);
status = CameraCameraSuccess(camera: camera);
await _controller.setZoomLevel(cameraZoom);
Expand Down Expand Up @@ -152,7 +152,16 @@ class CameraCameraController {

double get aspectRatio => _controller.value.aspectRatio;

Widget buildPreview() => _controller.buildPreview();
Widget buildPreview() {
var aspectRatio = _controller.value.aspectRatio;
if (aspectRatio > 1) {
aspectRatio = 1 / aspectRatio;
}
return AspectRatio(
aspectRatio: aspectRatio,
child: _controller.buildPreview(),
);
}

DeviceOrientation getApplicableOrientation() {
return _controller.value.isRecordingVideo
Expand Down
Loading