Add manage_all_configs parameter to remove old configurations#6
Open
davidalexander83 wants to merge 2 commits intogabe-sky:masterfrom
Open
Add manage_all_configs parameter to remove old configurations#6davidalexander83 wants to merge 2 commits intogabe-sky:masterfrom
davidalexander83 wants to merge 2 commits intogabe-sky:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you install and/or run ngrok manually prior to Puppet management, it will create /home/username/.ngrok2/ngrok.yml for any user that runs it.
ngrok will process these configurations first, prior to any configuration in /etc/ngrok.yml. Doesn't seem to always happen but happens more often than not.
This PR employs a recursive tidy resource to remove any ngrok.yml files found in /home, triggered by specifying $manage_all_configs => true. The readme has also been updated to reflect this with an example.
The default is $manage_all_configs => false so that we are non-destructive in our management.