Skip to content

fix: chrome.runtime.sendMessage now returns a Promise #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sun-yryr wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix: chrome.runtime.sendMessage now returns a Promise #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/messaging/implementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ export function buildMessenger(chromeApi: ChromeApi): CrossScriptMessenger {
chromeApi.runtime.onMessage.addListener(callback);
},
send(message) {
chromeApi.runtime.sendMessage(message);
// In manifest v3, sendMessage returns a Promise that rejects if no receiver exists.
// We need to catch and ignore this error to prevent uncaught promise rejections.
chromeApi.runtime.sendMessage(message).catch((error) => {
console.debug("Message send failed", { message, error });
});
},
};
}
Loading