Add small vibration when the MoreKeys Panel opens#1891
Open
BastianTrifork wants to merge 1 commit intofuto-org:masterfrom
Open
Add small vibration when the MoreKeys Panel opens#1891BastianTrifork wants to merge 1 commit intofuto-org:masterfrom
BastianTrifork wants to merge 1 commit intofuto-org:masterfrom
Conversation
Collaborator
|
Thank you for your contribution! Unfortunately, the code doesn't compile as-is and fails with the following errors It's usually a good idea to build and test your changes before opening a PR. You can find build instructions in the README: https://github.com/futo-org/android-keyboard?tab=readme-ov-file#building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add haptic feedback when opening more-keys popup
Feature: Implements #1550
Summary
This PR adds haptic feedback when the more-keys popup (shown on long-press for accents, symbols, etc.) is opened. The feedback uses the existing "Vibrate on keypress" setting, so users who have vibration enabled will now also get a short vibration when the popup appears.
Details:
Motivation
This improves the user experience for those accustomed to haptic feedback on popups (e.g., from Microsoft SwiftKey), providing a more responsive and tactile feel.
This is my first PR to a public project, If i need to change anything, please let me know :)
Closes #1550.