Add haptic feedback for spacebar and backspace swipe gestures#1876
Open
liketheduck wants to merge 2 commits intofuto-org:masterfrom
Open
Add haptic feedback for spacebar and backspace swipe gestures#1876liketheduck wants to merge 2 commits intofuto-org:masterfrom
liketheduck wants to merge 2 commits intofuto-org:masterfrom
Conversation
Vibrate briefly (5ms) on each cursor step when swiping the spacebar to move the cursor, giving tactile confirmation of character-by-character movement. The vibration respects the user's haptic feedback setting and does not fire during language-swipe mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extends the spacebar cursor haptic feedback to also cover the backspace swipe gesture, using the same vibration duration and settings check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zvonimir-FUTO
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds per-step haptic feedback when swiping the spacebar to move the cursor and when swiping backspace to delete. Uses the existing
AudioAndHapticFeedbackManagerwith a short 5ms vibration pulse per cursor step, gated by the user's vibration preference (settingsValues.mVibrateOn).Closes #747. Also addresses the related request in #693 and #862 (duplicates merged into #747) and the comment requesting the same treatment for gesture delete.
Changes
PointerTracker.java: AddedCURSOR_MOVE_VIBRATION_DURATIONconstant (5ms) and haptic feedback calls afteronMovePointer()(spacebar swipe) andonMoveDeletePointer()(backspace swipe).Test plan
Co-authored with Claude Code.