Fix buffer comparison in JansiLoader. #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rober710
force-pushed
the
fix-buffer-comparison
branch
from
3a78d57 to
92cfb29
Compare
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color output in maven stopped working some time ago in Fedora. I don't remember if the issue started happening in Fedora 41 or Fedora 43, though.
Debugging the issue, it seems that (at least with JDK 21), reading n bytes from an input stream, where n is lower than the buffer length, doesn't clear the remaining buffer with zeroes, leaving those bytes as were retrieved from a previous read. This causes the comparison in
JansiLoader.contentsEqualsto fail, as it's comparing the full buffer length, instead of taking into account the number of bytes read in each iteration.I'm seing the JDK target in the pom as 8, but in the github actions, I see the JDK is 9 and 11. May I update the target in the pom to JDK 9 as well? That allows me to use the
equalsmethod that supports comparing ranges. Otherwise, I'll have to manually clear the buffer with zeroes before reading, so that the comparison works.