BF: Screen Config can be bounding box. #1069
Conversation
maharshi-gor
commented
Jan 8, 2026
maharshi-gor
commented
- Fixed the calculate screen size to respect bbs.
- Added resize_callback for downstream.
- callback will be executed first and then regular resize functionality.
maharshi-gor
force-pushed
the
screen-config-fix
branch
2 times, most recently
from
daf8955 to
919e6bf
Compare
fury/window.py
Outdated
| if screens is None or not screens: | ||
| return [(0, 0, *size)] | ||
|
|
||
| if isinstance(screens[0], (tuple, list)): |
There was a problem hiding this comment.
I did not look at the rest of the codebase, I need to check
but why screens[0] and not screens[1]. I am sure there is a logic but I need to go deeper
There was a problem hiding this comment.
The screens[0] can be int in the case of basic configuration like
screens = [1, 2, 4]
Here each element means how many sections along the width and the number itself means how many sub-sections along the height in that particular section.
The more not used way is to provide the bounding boxes in which
screen = [(x0, y0 w0, h0), (x1, y1, w1, h1)]
Given that we can check all of the screen configuration. That will be bulletproof.
maharshi-gor
force-pushed
the
screen-config-fix
branch
from
919e6bf to
9fb9eca
Compare
| if screens is None or not screens: | ||
| return [(0, 0, *size)] | ||
|
|
||
| if all(isinstance(screen, (tuple, list)) for screen in screens): |
There was a problem hiding this comment.
ok, great!
I think it is ready to go but one last comment:
can you update the docstring of screens. It will help to understand. Thank you
- Fixed the calculate screen size to respect bbs. - Added resize_callback for downstream. - callback will be executed first and then regular resize functionality. - Test cases for valid bounding box
maharshi-gor
force-pushed
the
screen-config-fix
branch
from
9fb9eca to
1162c7e
Compare
skoudoro
left a comment
skoudoro
left a comment
There was a problem hiding this comment.
All good, Thanks @maharshi-gor, merging
2 participants
