Skip to content

Make easy-gd complient with Node 4.x.x#9

Open
y-a-v-a wants to merge 9 commits intofuragu:masterfrom
y-a-v-a:master
Open

Make easy-gd complient with Node 4.x.x#9
y-a-v-a wants to merge 9 commits intofuragu:masterfrom
y-a-v-a:master

Conversation

@y-a-v-a
Copy link

@y-a-v-a y-a-v-a commented Oct 11, 2015

Update node-gd to 1.1.0 and still get it to work with node@0.12.7 also.

@furagu
Copy link
Owner

furagu commented Oct 12, 2015

Hey Vincent,

thanks for your PR. Probably it is worth to drop the old node.js versions support, so I will investigate the matter and merge.

@y-a-v-a
Copy link
Author

y-a-v-a commented Oct 12, 2015

Hi thanks for the reply. Yes I think the build breaks for 0.9 and 0.8 due to changes in dependencies.
As said, it builds and passes npm test for nodejs 4.1.2 and 0.12.7. No idea how it builds on 0.10.x.
I think support for 0.12.x is still valuable, support for 0.10.x can be debatable ;-)

@kaanon
Copy link

kaanon commented Dec 9, 2015

i'm using this fork. Works great!

@Spalland
Copy link

Any news on whether this will be merged?

@MatthD
Copy link

MatthD commented Mar 2, 2016

Yes y-a-v-a Is working great !!!

@y-a-v-a
Copy link
Author

y-a-v-a commented Mar 31, 2016

Ok so I modified the configuration for travis a bit so we drop support for nodejs 0.9. As travis shows, still builds nicely on 0.10, 0.12 and 4.3. If you don't mind dropping support for 0.9, you could merge this PR.
Regards,
Vincent

@y-a-v-a
Copy link
Author

y-a-v-a commented Apr 4, 2016

@furagu any chance you have time to look into this PR / merge it / publish it to NPM? Would be great.

@y-a-v-a
Copy link
Author

y-a-v-a commented Jun 29, 2016

Hi @furagu we've added some updates, extended nodejs version support. Could you merge & publish to npm? Or add me as a maintainer in npm so I could publish a new version myself?
Thanks in advance!

@dekatron
Copy link

@furagu would be great if this could get merged (or if you could add y-a-v-a as a maintainer) on up to date systems with older versions of node I have an issue with node-gyp as it's not compatible with python3 which prevents me from installing easy-gd, on systems with a more recent version of node I can't install because easy-gd isn't compatible. This branch fixes the issue so would be really helpful to anyone in a similar situation.

@kodie
Copy link

kodie commented Dec 16, 2016

@furagu +1 for merging this or making @y-a-v-a a maintainer

@y-a-v-a
Copy link
Author

y-a-v-a commented Sep 22, 2017

Updated easy-gd to use node-gd@1.5.0 and buffertools@2.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants