run on Plone 5.1 with or without plone.login

[holdenhao]

No description provided.

[fulv]

Just checking, until your last commit, this and #2 seemed to be identical. Why did you close #2?

[holdenhao]

Sorry. New to this. I thought the PR was just for the commit at the time of request. So I closed the one with build errors. BTW, I have issues with the keyword I used for selective redirects in 63e72b2. The came_from value 'onlogin_redirect' disappears in a modal. But if the keyword is 'redirect_on' it is fine. Still debugging. Also, I am not sure it is a good feature to have in the official add-on. But we need it for our case.

[fulv]

The modal has some issues that make it tricky to work with, and what you are observing may not have anything to do with this addon.

[holdenhao]

My latest commit fixed the issue with the keyword I used. The word login is being checked by plone.login and if used in came_from the redirect will not work. So I am using the keyword redirect_on instead.