Shrink the window size for time zone transition search#79
Open
fabon-f wants to merge 1 commit intofullcalendar:mainfrom
Open
Shrink the window size for time zone transition search#79fabon-f wants to merge 1 commit intofullcalendar:mainfrom
fabon-f wants to merge 1 commit intofullcalendar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix the bug of
startOfDay,getTimeZoneTransitiondue to too wide window size. It will also fix offset calculation bug ofZonedDateTimepartially.This is a provisional fix until "a more robust algorithm" mentioned in #73 (comment) will be introduced.
If we want to extend the window more, we have to hardcode "unusual" time zones and change the window size for each time zone ID, which isn't possible by design for now. (cf. tc39/proposal-temporal#3112)
I'm not even sure hardcoding is reasonable from the perspective of bundle size, because extending the window only affect performance of
getTimeZoneTransition(which itself is API for power users and therefore rarely used) when an offset transition doesn't exist few days after or beforeZonedDateTime, which is (I guess) very uncommon case. For example,startOfDayusesgetTimeZoneTransitioninternally, but it is guaranteed that an offset transition exists in 2 days in this case, so the window size is irrelevant.