Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/dependabot.yml

This file was deleted.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ A library with common Java types that are mostly immutable value objects.
[![Java Development Kit 17](https://img.shields.io/badge/JDK-17-green.svg)](https://openjdk.java.net/projects/jdk/17/)

## Versions
- 0.10.0 = See [Release Notes](release-notes.md)
- [0.11.0](release-notes.md#0110)
- [0.10.0](release-notes.md#0100)
- 0.9.0 = **Java 17**
- 0.8.0 = **Java 11** with new **jakarta** namespace
- 0.7.x = **Java 11** before namespace change from 'javax' to 'jakarta'
Expand Down
2 changes: 1 addition & 1 deletion common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>org.fuin.objects4j</groupId>
<artifactId>objects4j-parent</artifactId>
<version>0.10.0</version>
<version>0.11.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
*/
package org.fuin.objects4j.common;

import org.fuin.objects4j.common.ValueObjectWithBaseType;

/**
* Converts a value object into it's base type and back.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,8 @@ public final class FileExistsValidatorTest {
public final void setUp() throws IOException {
testee = new FileExistsValidator();
existingFile = new File(Utils4J.getTempDir(), "FileExistsValidatorTest_File");
final OutputStream out = new FileOutputStream(existingFile);
try {
try (final OutputStream out = new FileOutputStream(existingFile)) {
out.write("Test".getBytes());
} finally {
out.close();
}
existingDir = new File(Utils4J.getTempDir(), "FileExistsValidatorTest_Dir");
existingDir.mkdir();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public static boolean isValid(String str) {

@HasPublicStaticIsValidMethod
public static final class MyClassNotStatic {
@SuppressWarnings("java:S1172") // Unused method parameter is ok here
public boolean isValid(String str) {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ public static Integer valueOf(String str) {

@HasPublicStaticValueOfMethod
public static final class MyClassWrongReturnValue {
@SuppressWarnings("java:S1172") // Unused method parameter is ok here
public static MyClassWrongReturnValue valueOf(String str) {
return new MyClassWrongReturnValue();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,8 @@ public final class IsDirectoryValidatorTest {
public final void setUp() throws IOException {
testee = new IsDirectoryValidator();
existingFile = new File(Utils4J.getTempDir(), "IsDirectoryValidatorTest_File");
final OutputStream out = new FileOutputStream(existingFile);
try {
try (final OutputStream out = new FileOutputStream(existingFile)) {
out.write("Test".getBytes());
} finally {
out.close();
}
existingDir = new File(Utils4J.getTempDir(), "IsDirectoryValidatorTest_Dir");
existingDir.mkdir();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,8 @@ public final class IsFileValidatorTest {
public final void setUp() throws IOException {
testee = new IsFileValidator();
existingFile = new File(Utils4J.getTempDir(), "IsFileValidatorTest_File");
final OutputStream out = new FileOutputStream(existingFile);
try {
try (final OutputStream out = new FileOutputStream(existingFile)) {
out.write("Test".getBytes());
} finally {
out.close();
}
existingDir = new File(Utils4J.getTempDir(), "IsFileValidatorTest_Dir");
existingDir.mkdir();
Expand Down
2 changes: 1 addition & 1 deletion core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>org.fuin.objects4j</groupId>
<artifactId>objects4j-parent</artifactId>
<version>0.10.0</version>
<version>0.11.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ void testEqualsHashCode() {
}

@Test
@SuppressWarnings("java:S117") // Underscore in var name is ok here
void testCompareTo() {

final CurrencyAmount eur123_2 = new CurrencyAmount(bd(123, 2), cu("EUR"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public final void tearDown() {

@Test
void testValidConstantLowerCase() {

final String value = "089ba5d3-1027-421d-add7-7e65f95b6ed6";
assertThat(testee.isValid(value, null)).isTrue();
assertThat(UUIDStrValidator.parseArg("a", value)).isEqualTo(UUID.fromString(value));
Expand All @@ -53,7 +52,7 @@ void testValidConstantLowerCase() {

@Test
void testValidConstantUpperCase() {
final String value = "089ba5d3-1027-421d-add7-7e65f95b6ed6";
final String value = "089BA5D3-1027-421D-ADD7-7E65F95B6ED6";
assertThat(testee.isValid(value, null)).isTrue();
assertThat(UUIDStrValidator.parseArg("a", value)).isEqualTo(UUID.fromString(value));
}
Expand Down Expand Up @@ -117,10 +116,5 @@ void testInvalidSpecialCharacters() {

}

@Test
void testParseArg() {

}

}
// CHECKSTYLE:ON
13 changes: 6 additions & 7 deletions jackson/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>org.fuin.objects4j</groupId>
<artifactId>objects4j-parent</artifactId>
<version>0.10.0</version>
<version>0.11.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand All @@ -17,6 +17,11 @@

<!-- Compile -->

<dependency>
<groupId>org.fuin</groupId>
<artifactId>utils4j</artifactId>
</dependency>

<dependency>
<groupId>org.fuin.objects4j</groupId>
<artifactId>objects4j-common</artifactId>
Expand Down Expand Up @@ -103,12 +108,6 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.fuin</groupId>
<artifactId>utils4j</artifactId>
<scope>test</scope>
</dependency>

</dependencies>

<build>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading