Draft HMAC, CONNECT, and stream metadata#2
Open
the-eater wants to merge 1 commit intoftl-protocol-dev:mainfrom
Open
Draft HMAC, CONNECT, and stream metadata#2the-eater wants to merge 1 commit intoftl-protocol-dev:mainfrom
the-eater wants to merge 1 commit intoftl-protocol-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not the best at writing coherent sentences and words, but this SHOULD™ be okay, let me know if it's just really bad tho
while writing this I already have an interesting divergence from your spec vs observations.
you note that metadata is send in RFC 822 format.
however as far as I am aware none of the open implementations support RFC 822 (there's a few gotcha's around it, like the handling of multiple headers with the same name and continuation of headers on new lines)
And we also directly violate it by the newline handling Charon does, resulting in our terminator not being a double newline, but a single line with a singular dot.
for this reason I had added that it MUST NOT be treated as RFC 822 3.2
I am okay with saying we do RFC 822 3.2 with some modifications, but I am unaware of any implementations respecting that