Skip to content

chore: update to cmake 3.10, enforce formatting with tooling#135

Merged
ptsouchlos merged 7 commits intomasterfrom
PT/cleanup-and-formatting
Sep 7, 2025
Merged

chore: update to cmake 3.10, enforce formatting with tooling#135
ptsouchlos merged 7 commits intomasterfrom
PT/cleanup-and-formatting

Conversation

@ptsouchlos
Copy link
Member

@ptsouchlos ptsouchlos commented Sep 7, 2025

Changes

  • Move to CMake 3.10 as minimum version.
  • Add clang-format file
  • Add optional build targets for checking and fixing formatting using clang-format
  • Added basic CI to build the project and check formatting on pushes and PRs

Closes #130

@ptsouchlos ptsouchlos requested a review from Copilot September 7, 2025 19:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the build system and enforces consistent code formatting by updating to CMake 3.10 and introducing clang-format tooling with automated CI formatting checks.

  • Updates minimum CMake version from 3.5 to 3.10
  • Adds clang-format configuration file and optional build targets for format checking/fixing
  • Implements GitHub Actions CI workflow to build the project and verify formatting

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated no comments.

File Description
CMakeLists.txt Updates minimum CMake version and adds optional clang-format targets
.clang-format Defines code formatting rules based on LLVM style
.github/workflows/linux.yml Adds CI workflow for building and format checking
src/.h, src/.cpp Applies clang-format styling to all source files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ptsouchlos ptsouchlos merged commit 841f8c8 into master Sep 7, 2025
2 checks passed
@ptsouchlos ptsouchlos deleted the PT/cleanup-and-formatting branch September 7, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE:DEV] Add clang-format rules

2 participants