#42 refactor Move into abstract class and subclasses #43
Open
barrybecker4 wants to merge 7 commits intofsparv:masterfrom
Open
#42 refactor Move into abstract class and subclasses #43barrybecker4 wants to merge 7 commits intofsparv:masterfrom
barrybecker4 wants to merge 7 commits intofsparv:masterfrom
Conversation
The EVENT parser is pretty fragile in the sense that if the initial text sent by autogtp changes at all, it can fail in a mysterious ways. I updated the regexp to accept the new text and still be backward compatible with old versions, but it could fail again in the future if the autogtp start text changes again. I bumped the version to 1.2.0 and also updated to gradle 6.2 and a newer version of the fatjar plugin. You can now build with java 11.
Add some generics where needed. Fix some warnings. Fix typos in doc. Remove some dead code.
Move Move into move subpackage in preparation for refactor.
Do the refactor into separate subclasses.
Contributor
Author
|
/review @fsparv |
…ttps://github.com/barrybecker4/LeelaWatcher into 40-fix-for-use-with-recent-autogtp � Conflicts: � src/main/java/leelawatcher/parser/AutoGtpOutputParser.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit in this PR is actually the same fix as in #40
The rest of it is the refactor for #42.