Skip to content

Conversation

@florenzen
Copy link
Collaborator

@florenzen florenzen commented Jan 5, 2026

Would you review this @davidglassborow?

@matthewcrews
Copy link
Contributor

@florenzen I haven't been actively developing .NET for a couple of years now, so I'm not sure how much help I could be.

@florenzen
Copy link
Collaborator Author

Sorry @matthewcrews, I meant to tag @davidglassborow.

@davidglassborow davidglassborow self-requested a review January 5, 2026 23:43
davidglassborow
davidglassborow previously approved these changes Jan 5, 2026
Copy link
Collaborator

@davidglassborow davidglassborow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could we leave a comment in the proj file specifying nuget properties come from paket.template to help anyone not brilliant with paket (like me ;-)

@florenzen
Copy link
Collaborator Author

Looks good. Could we leave a comment in the proj file specifying nuget properties come from paket.template to help anyone not brilliant with paket (like me ;-)

Yes, sure and done.

@florenzen
Copy link
Collaborator Author

Just need an approve @davidglassborow. Feel free to merge after approval.

@davidglassborow davidglassborow merged commit 8535b38 into main Jan 6, 2026
2 checks passed
@davidglassborow davidglassborow deleted the specify-nuget-package-metadata-only-in-template branch January 6, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants