Push notification passphrase #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional config field to set the passphrase for push notification certificate. Grocer makes it optional. Add spec for it, update readme with instructions. Increased patch version.
Owner
|
LGTM if you could also review @lgleasain |
|
👍 I was getting an error from apple for not including this header, but updating to this branch worked for me. I also ran into the passphrase issue, but I worked around it by using Grocer's notification API directly: pusher = Grocer.pusher(
certificate: Passbook.notification_cert,
passphrase: Passbook.p12_password,
gateway: Rails.env.test? ? "localhost" : "gateway.push.apple.com",
)
PassbookDevice.find_each do |device|
notification = Grocer::PassbookNotification.new(device_token: device.push_token)
pusher.push(notification)
endThanks for pushing this fix, I hope it can be merged soon! |
Contributor
Author
|
@frozon Changed the way empty passphrase is handled, brought down the version bump and squashed the commits. 👍 |
Owner
|
Thanks for your work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Push notification passphrase as config attribute.
Merge last-modified header feature from #26