Skip to content

fix: inline parsing edge case with nested emphasis#242

Merged
frostming merged 1 commit intofrostming:masterfrom
ll3006:master
Oct 10, 2025
Merged

fix: inline parsing edge case with nested emphasis#242
frostming merged 1 commit intofrostming:masterfrom
ll3006:master

Conversation

@ll3006
Copy link
Contributor

@ll3006 ll3006 commented Oct 7, 2025

Fixes #241

before this, parsing would differ from CommonMark reference
implementation, giving '<p>**a_{b}**</p>' for '**a_{b}**'.

changes:
* decrease cur after deleting a delimiter with can_open = False
* add test
@ll3006 ll3006 changed the title fix: parsing issue edge case with nested emphasis fix: inline parsing edge case with nested emphasis Oct 9, 2025
@ll3006
Copy link
Contributor Author

ll3006 commented Oct 9, 2025

  • Fixed incorrect commit body (previously said "..with can_open = True" when it should have been "...with can_open = False")
  • Fixed commit subject line to improve legibility

@frostming frostming merged commit 4bf4fe8 into frostming:master Oct 10, 2025
19 checks passed
@frostming
Copy link
Owner

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline emphasis edge case differs from CommonMark spec

2 participants