Feature add blink doorbell without sync module#1208
Open
gal-nir wants to merge 2 commits intofronzbot:devfrom
Open
Feature add blink doorbell without sync module#1208gal-nir wants to merge 2 commits intofronzbot:devfrom
gal-nir wants to merge 2 commits intofronzbot:devfrom
Conversation
modified: blinkpy/sync_module.py modified: tests/test_blinkpy.py modified: tests/test_sync_module.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes discovery for sync-less doorbells when a sync-less mini exists on the same network ID.
Uses homescreen parsing helpers for minis/doorbells (including alternate doorbell payload keys like lotus).
Only treats a device as "attached to sync module" when a real sync module exists for that network.
Prevents camera-list merge drops when a network is absent from camera/usage.
Adds regression tests for alternate homescreen keys and sync-less doorbell behavior.
Reproduction
Account with:
Blink Mini (sync-less)
Blink Doorbell (sync-less)
Both appear in homescreen.
camera/usage returns empty cameras list for that network.
Before
Only mini appeared in blink.cameras.
Doorbell was skipped.
After
Both mini and doorbell appear in blink.cameras.
Doorbell supports existing BlinkLotus flow correctly.
Test plan