Fix rake update-select2 and update locale assets#1
Open
nilbus wants to merge 2 commits intofrodrigo:v4from
Open
Fix rake update-select2 and update locale assets#1nilbus wants to merge 2 commits intofrodrigo:v4from
nilbus wants to merge 2 commits intofrodrigo:v4from
Conversation
It was still calling SourceFile#convert, which has been removed. SourceFile#convert is no longer necessary, because select2 4.0.0 no longer uses image assets.
These assets had not been updated since beta2. Note that languages ja and ms are *not* present in select2 4.0.0 but will be present in the next release (because they are currently in master).
nilbus
force-pushed
the
v4
branch
2 times, most recently
from
c63b9a7 to
699d34c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all I see that is needed for merge into argerim/select2-rails:master. I will test this branch in my app and confirm that everything works too.