Refactor focus management as template effects #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inventory containers now use implicit focus only: - Remove escape option from inventory thread autocomplete - Remove handle_escape() function from shared.py - Block open/close verbs on inventory items with clear message - Remove "escape" source from entity resolution Inventory containers are always "open" when viewed in their thread, with no explicit focus state to manage. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
frizzle-chan
force-pushed
the
refactor-focus-effect
branch
from
d132c2e to
63400b6
Compare
Update base-room entity to handle all verbs (touch, attack, use, take, open, close, drop) by clearing focus and showing room description. This ensures rooms respond consistently to any action directed at them. Add documentation in CLAUDE.md explaining the pattern for adding new triggers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
effects.set_focus()andeffects.clear_focus()template functions, allowing any handler to control focus state instead of relying on thefocus_modeschema columnroom:<room_id>) with unified resolution path, eliminating hardcoded[Close X] Roomescape logicRoomContextfor lazy room data access in templates withroom.description()androom.entities()functions/lookand/interactcogsSee ADR 0006 for detailed rationale and migration path.
Test plan
/lookwith no target shows room description via room entityeffects.set_focus()inon_openeffects.clear_focus()inon_close🤖 Generated with Claude Code