Used ES6 syntax to use React's { Component } instead of referencing it as React.Component#440
Open
sagarhani wants to merge 1 commit intofrintjs:masterfrom
Open
Used ES6 syntax to use React's { Component } instead of referencing it as React.Component#440sagarhani wants to merge 1 commit intofrintjs:masterfrom
sagarhani wants to merge 1 commit intofrintjs:masterfrom
Conversation
…t as React.Component
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 112 112
Lines 4386 4386
=======================================
Hits 4288 4288
Misses 98 98Continue to review full report at Codecov.
|
armand1m
approved these changes
Sep 22, 2018
leandrooriente
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of referencing React.Component we can use ES6 to pull Component from React by saying :
import React, { Component } from 'react';And, use
Componentdirectly instead ofReact.Component🍪