Updated implementation of query named parameters#169
Updated implementation of query named parameters#169Divi wants to merge 2 commits intofriends-of-reactphp:0.7.xfrom
Conversation
SimonFrings
left a comment
There was a problem hiding this comment.
Hey @Divi, thanks for opening this pull request, always happy about contributions 👍 👍
I really like the quality of this PR, just left a single remark below.
SimonFrings
left a comment
There was a problem hiding this comment.
Looks good, thanks for your work on this 👍
|
@Divi Thanks for looking into this, would love to get this in! The additional tests are much appreciated, definitely helps to get some certainty with this feature. It looks like some cases aren't covered right now, can you add some additional tests to ensure this works properly when using the same placeholder name multiple times ( |
|
Just to let you know, I've not forgotten you, I just don't have enough time for now but I keep in mind your request :) |
Hello!
I saw a previous pull request about the named parameters. Since there is no activity for 3 years now, I took the liberty to make my own implementation and update the unit tests.
It allows:
Of course, all the previous ways of querying still work.
I can update the README if needed.