This repository was archived by the owner on Jan 4, 2021. It is now read-only.
Update Dockerfile #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaudeanadams
commented
Mar 11, 2020
beaudeanadams
commented
- Updated Dockerfile to best practice
- Updated python version to 3.8
Updated Dockerfile to best practice
Removed APP_VERSION from Dockerfile. APP_VERSION is set in settings.py
Owner
|
Hey. Is there a reason we can't have the APP_VERSION set in the Dockerfile? It would be easier to update the container if there is an update |
|
There is no reason that you cannot set APP_VERSION as an ENV in the Dockerfile also, however it would need manual overriding on runtime as the version changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.