Skip to content
This repository was archived by the owner on Jan 7, 2026. It is now read-only.

Conversation

@fretchen
Copy link
Owner

There are still a few weird things in the code. Quite importantly as I run pylint right now he gives me:

pylint SynthHDDevice
************* Module SynthHDDevice
SynthHDDevice/__init__.py:1:0: C0103: Module name "SynthHDDevice" doesn't conform to snake_case naming style (invalid-name)
************* Module SynthHDDevice.blacs_tabs
SynthHDDevice/blacs_tabs.py:10:0: W0223: Method 'start_run' is abstract in class 'DeviceTab' but is not overridden (abstract-method)
************* Module SynthHDDevice.blacs_workers
SynthHDDevice/blacs_workers.py:19:4: W0231: __init__ method from base class 'Worker' is not called (super-init-not-called)
************* Module SynthHDDevice.labscript_devices
SynthHDDevice/labscript_devices.py:30:8: C0103: Attribute name "BLACS_connection" doesn't conform to snake_case naming style (invalid-name)
SynthHDDevice/labscript_devices.py:20:46: W0613: Unused argument 'baud_rate' (unused-argument)
  • The first important one is that the baud_rate is never used. Why ?
  • The second weird one is that the __init__ function is called for the worker instead of init like for all the other workers in other devices. Why?

There are still a few weird things in the code.
@fretchen fretchen requested a review from nalilab April 17, 2020 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants