Merged
Conversation
doesnt compile but the idea is that it would be more safe to update the watch descriptors of the previous files so that we can check valid descriptors in the event loop
i think its safe not to even check if the wd is below offset, it would be much faster and if inotify is sending it than it must already be valid. ill leave this commit as the basis for an idea though
creates a bit of a bug where the wd will only be updated once another file is modified
freref
commented
Feb 19, 2025
src/watchers/macos.zig
Outdated
| const flags = eventFlags[i]; | ||
| if (flags & c.kFSEventStreamEventFlagItemModified != 0) { | ||
| self.callback.?(self.context, interfaces.Event.modified); | ||
| self.callback.?(self.context, .{ .kind = .modified, .index = i }); |
Owner
Author
There was a problem hiding this comment.
This is the index for events, not for files
Owner
Author
|
Merging the bug fixes without returning index of the file because I'm unsure of the best implementation, made issue #6 to track this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.