Override Formula.cancel() and .wait() rather than .stop()#1375
Merged
simonvoelcker merged 2 commits intofrequenz-floss:v1.x.xfrom Mar 17, 2026
Merged
Override Formula.cancel() and .wait() rather than .stop()#1375simonvoelcker merged 2 commits intofrequenz-floss:v1.x.xfrom
simonvoelcker merged 2 commits intofrequenz-floss:v1.x.xfrom
Conversation
simonvoelcker
added
type:bug
github-actions
bot
added
part:docs
simonvoelcker
requested review from
daniel-zullo-frequenz
and removed request for
a team
llucax
reviewed
Mar 17, 2026
simonvoelcker
force-pushed
the
formula_cancel_and_wait
branch
from
091f48d to
4def8e9
Compare
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
simonvoelcker
force-pushed
the
formula_cancel_and_wait
branch
from
4def8e9 to
5121835
Compare
llucax
approved these changes
Mar 17, 2026
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1327.
Before this change, stopping a Formula would not stop the evaluator or any sub-formulas. The BackgroundService base class calls cancel() and wait(), but these must be overridden correctly to also cancel/await the evaluator and sub-formulas.